Summary: | Crashes caused by DebugController::showStepInSource() when a user requests KDevelop exit just before a code breakpoint is hit | ||
---|---|---|---|
Product: | [Applications] kdevelop | Reporter: | Igor Kushnir <igorkuo> |
Component: | CPP Debugger | Assignee: | Igor Kushnir <igorkuo> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | niko.sams, willyanto39 |
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kdevelop/kdevelop/commit/300ea0143f4dcf5537cac824e823bee1ce6077fc | Version Fixed In: | 5.6.1 |
Description
Igor Kushnir
2020-08-30 16:00:23 UTC
*** Bug 426371 has been marked as a duplicate of this bug. *** Git commit 300ea0143f4dcf5537cac824e823bee1ce6077fc by Igor Kushnir. Committed on 15/10/2020 at 15:26. Pushed by igorkushnir into branch '5.6'. Do not open documents after DocumentController::cleanup() For now d->shuttingDown is checked in just one of many DocumentController::openDocument() overloads and alternatives, because this is the only overload that is known to be called after cleanup() and cause crashes. If similar crashes happen because of other ways of opening a document, the check can be moved or reused elsewhere. Or perhaps a different strategy will be needed to fix these hypothetical future crashes: e.g. simply returning nullptr doesn't work if the caller dereferences the returned document pointer without checking. FIXED-IN: 5.6.1 M +17 -0 kdevplatform/shell/documentcontroller.cpp https://invent.kde.org/kdevelop/kdevelop/commit/300ea0143f4dcf5537cac824e823bee1ce6077fc |