| Summary: | Notification countdown circle is no longer matching close icon | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Kai Uwe Broulik <kde> |
| Component: | Notifications | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, plasma-bugs, popov895 |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.19.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/6d2ef8e25612d0c125190983bfed90bec106ec00 | Version Fixed In: | 5.20.1 |
| Attachments: |
Circle screenshot
Non-default font size The indicator is hidden behind the icon |
||
Works for me at 250% scale with Qt scaling, FWIW. Does it work if you turn on Qt scaling with PLASMA_USE_QT_SCALING=1? Yes, but it messes with my desktop in other interesting ways. Working on a fix. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/235 Created attachment 132362 [details]
Non-default font size
The patch doesn't work if set a font size different than the default
Git commit 07992bc4abd6e9a3c4d1397eb051dfba50715010 by Nate Graham. Committed on 16/10/2020 at 12:38. Pushed by ngraham into branch 'master'. [notifications] Fix margins of close button timeout indicator The previous calculation multiplied the DPR by `units.smallSpacing`, which was not correct; we wanted DPR added to the existing margin, not multiplied by it. Also using Math.floor is safer since Math.round sometimes rounds up (e.g. in case DPR is 2.501) which can cause undesirable effects. M +2 -2 applets/notifications/package/contents/ui/NotificationHeader.qml https://invent.kde.org/plasma/plasma-workspace/commit/07992bc4abd6e9a3c4d1397eb051dfba50715010 Git commit 6d2ef8e25612d0c125190983bfed90bec106ec00 by Nate Graham. Committed on 16/10/2020 at 12:39. Pushed by ngraham into branch 'Plasma/5.20'. [notifications] Fix margins of close button timeout indicator The previous calculation multiplied the DPR by `units.smallSpacing`, which was not correct; we wanted DPR added to the existing margin, not multiplied by it. Also using Math.floor is safer since Math.round sometimes rounds up (e.g. in case DPR is 2.501) which can cause undesirable effects. (cherry picked from commit 07992bc4abd6e9a3c4d1397eb051dfba50715010) M +2 -2 applets/notifications/package/contents/ui/NotificationHeader.qml https://invent.kde.org/plasma/plasma-workspace/commit/6d2ef8e25612d0c125190983bfed90bec106ec00 As I said in Comment 6, this bug can still be reproduced by setting the font size to be larger than the default. Created attachment 132628 [details]
The indicator is hidden behind the icon
That's the intended appearance now. :) Really? It's better to completely remove this indicator than to leave it as it's now. |
Created attachment 131246 [details] Circle screenshot SUMMARY Before meddling with ToolButton icon sizes, the circle would encompass the close icon. Now it is overlapping which looks bad. STEPS TO REPRODUCE 1. Have a screen with 2x scaling I guess and dont use Qt scaling in plasma 2. get a notification 3. OBSERVED RESULT Countdown circle looks bad EXPECTED RESULT Countdown circle looks good SOFTWARE/OS VERSIONS Linux/KDE Plasma: (available in About System) KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.74 Qt Version: 5.14.2