Bug 425821

Summary:	coretaggedfileiconprovider.h:90:11: error: unknown type name 'QByteArray'
Product:	[Applications] kid3	Reporter:	Tomasz Paweł Gajc <tpgxyz>
Component:	general	Assignee:	Urs Fleisch <ufleisch>
Status:	RESOLVED WORKSFORME
Severity:	normal
Priority:	NOR
Version First Reported In:	3.8.x
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Tomasz Paweł Gajc 2020-08-26 09:11:14 UTC

SUMMARY
3.8.3 version does not compile with Qt 5.15.0

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT
Full logs https://abf.openmandriva.org/build_lists/817595

FAILED: src/core/CMakeFiles/kid3-core.dir/model/coretaggedfileiconprovider.cpp.o 
/usr/bin/clang++ -DKID3_BUILD_CORE_LIB -DKID3_BUILD_PLUGIN_LIB -DQT_ASCII_CAST_WARNINGS -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_EXCEPTIONS -DQT_NO_STL -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_XML_LIB -I../ -I. -I../src/core/utils -I../src/core/config -I../src/core/tags -I../src/core/export -I../src/core/import -I../src/core/model -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/./mkspecs/linux-clang -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtDBus -Os -fomit-frame-pointer -g1 -Wstrict-aliasing=2 -pipe -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fstack-protector-all --param=ssp-buffer-size=4 -m64 -mtune=generic -flto -Wundef -Wcast-align -Wall -W -Wpointer-arith -Woverloaded-virtual -fno-common -Werror=return-type -Wweak-vtables -D_REENTRANT -fvisibility=hidden -fvisibility-inlines-hidden -Os -fomit-frame-pointer -g1 -Wstrict-aliasing=2 -pipe -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fstack-protector-all --param=ssp-buffer-size=4 -m64 -mtune=generic -flto -DQT_NO_DEBUG -fPIC -MD -MT src/core/CMakeFiles/kid3-core.dir/model/coretaggedfileiconprovider.cpp.o -MF src/core/CMakeFiles/kid3-core.dir/model/coretaggedfileiconprovider.cpp.o.d -o src/core/CMakeFiles/kid3-core.dir/model/coretaggedfileiconprovider.cpp.o -c ../src/core/model/coretaggedfileiconprovider.cpp
In file included from ../src/core/model/coretaggedfileiconprovider.cpp:27:
../src/core/model/coretaggedfileiconprovider.h:90:11: error: unknown type name 'QByteArray'
  virtual QByteArray iconIdForTaggedFile(const TaggedFile* taggedFile) const;
          ^
../src/core/model/coretaggedfileiconprovider.h:98:42: error: unknown type name 'QByteArray'
  virtual QVariant pixmapForIconId(const QByteArray& id);
                                         ^
../src/core/model/coretaggedfileiconprovider.cpp:109:38: error: out-of-line definition of 'pixmapForIconId' does not match any declaration in 'CoreTaggedFileIconProvider'
QVariant CoreTaggedFileIconProvider::pixmapForIconId(const QByteArray& id)
                                     ^~~~~~~~~~~~~~~
3 errors generated.

EXPECTED RESULT
No errors

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: OpenMandriva Lx Cooker
(available in About System)
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.73
Qt Version: 5.15.0

ADDITIONAL INFORMATION
LLVM/clang-11.x is default compiler

Comment 1 Urs Fleisch 2020-08-27 14:35:40 UTC

Thanks for the report. This is strange, I am building Kid3 with Qt 5.15.0 too (on Arch Linux) and I am not getting this error. coretaggedfileiconprovider.cpp includes taggedfile.h, which includes QString, which includes qstring.h, which include qbytearray.h. Is this not the case in your setup? So why do you get "error: unknown type name 'QByteArray'"?