Bug 425812

Summary: No asterisk on tab in tabbed mode when the document is modified
Product: [Applications] krita Reporter: Tiar <tamtamy.tymona>
Component: GeneralAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: ahab.greybeard, dimula73
Priority: NOR Keywords: regression
Version: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Mint (Ubuntu based)   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: No asterisk on the tab, while there is asterisk on the titlebar

Description Tiar 2020-08-26 01:04:48 UTC
Created attachment 131188 [details]
No asterisk on the tab, while there is asterisk on the titlebar

SUMMARY
In Krita 4.3.0 in tabbed mode modified documents were marked with asterisk on the tab.
On stable branch (future 4.4.0) right now the asterisk only appears on the title bar, but not on the tabs.
Since I look at the tab to see if the document is modified, it really bothers me that I don't have this information now.

I believe it must be the result of recent changes to the titlebar (removed version from dev build, something like that?).

STEPS TO REPRODUCE
1. Open multiple documents in Krita 4.3.0. Modify one or more. Switch between documents.
2. Do the same with Krita 4.4.0-alpha build.

OBSERVED RESULT
No asterisk on tabs in Krita 4.4.0-alpha build, even if the document is modified. It looks just like in Krita 4.3.0 when the document was *not* modified. The name of the document still is there, so the user doesn't suspect that anything is different now.

EXPECTED RESULT
Asterisk on tabs.

SOFTWARE/OS VERSIONS
Krita version: 4.4.0-alpha (git 2859f85)
I used an appimage.
Comment 1 Ahab Greybeard 2020-08-26 10:49:10 UTC
I can confirm this for the Aug25 4.4.0 alpha (git f501273) and the 5.0.0 prealpha (git f2d3c13) appimages.
It's also the case for subwindow mode.
Comment 2 Halla Rempt 2020-08-26 12:24:45 UTC
Git commit 8f2fe10c9a179134471f01cc1df385d9aba57dde by Boudewijn Rempt.
Committed on 26/08/2020 at 12:24.
Pushed by rempt into branch 'master'.

(cherry picked from commit a09eb0243c2c255d699f4dc4ae3cb82c5404ab74)

M  +7    -1    libs/ui/KisMainWindow.cpp

https://invent.kde.org/graphics/krita/commit/8f2fe10c9a179134471f01cc1df385d9aba57dde
Comment 3 Halla Rempt 2020-08-26 12:24:54 UTC
Git commit a09eb0243c2c255d699f4dc4ae3cb82c5404ab74 by Boudewijn Rempt.
Committed on 26/08/2020 at 12:23.
Pushed by rempt into branch 'rempt/resourcemodel_rewrite'.

M  +7    -1    libs/ui/KisMainWindow.cpp

https://invent.kde.org/graphics/krita/commit/a09eb0243c2c255d699f4dc4ae3cb82c5404ab74
Comment 4 Halla Rempt 2020-08-26 12:25:23 UTC
Git commit 6f363dbbae28ad32eaddd5f5ab2252de7190eb30 by Boudewijn Rempt.
Committed on 26/08/2020 at 12:24.
Pushed by rempt into branch 'krita/4.3'.

(cherry picked from commit a09eb0243c2c255d699f4dc4ae3cb82c5404ab74)

M  +7    -1    libs/ui/KisMainWindow.cpp

https://invent.kde.org/graphics/krita/commit/6f363dbbae28ad32eaddd5f5ab2252de7190eb30