Bug 425739

Summary: "Sort by" toolbar button absolutely not consistent with Dolphin's: Has text, needs long press to change order
Product: [Applications] gwenview Reporter: postix <postix>
Component: generalAssignee: Gwenview Bugs <gwenview-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: nate, postix
Priority: NOR Keywords: usability
Version First Reported In: 20.08.0   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: https://invent.kde.org/graphics/gwenview/commit/5bcfd5b83ca86cebceb9cc08d5dded00ca6819cb Version Fixed/Implemented In: 20.08.1
Sentry Crash Report:

Description postix 2020-08-24 10:47:20 UTC 
The toolbar is quiet convenient to have quick access to often used functions, such as "Sort by".
However, the "Sort By" toolbar button in it's current state is not useful to me at all. 

As a user I'd assume that all images and video files are sorted automatically by the sort key defined in "View" -> "Sort By".
I.e. selecting another sort order would automatically rearrange the list of files.

The "Sort By" toolbar button seems to follow a different behaviour: "Sort on click" but "long click to choose sort key/order".
I don't think this is how it should be and is e.g. not consistent with Dolphin's "Sort By" toolbar button, which I'd say is what Gwenview should adept to.

Secondly, the toolbar button has a long text, despite setting "Show Icon only".


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.0
Comment 1 Nate Graham 2020-08-24 22:45:34 UTC 
Yeah that's silly. I'll fix it.
Comment 2 Nate Graham 2020-08-24 22:57:24 UTC 
Git commit 5bcfd5b83ca86cebceb9cc08d5dded00ca6819cb by Nate Graham.
Committed on 24/08/2020 at 22:56.
Pushed by ngraham into branch 'release/20.08'.

Make "Sort By" menu work properly

Requiring click-and-hold makes no sense. Also add an icon while we're
fixing that.
FIXED-IN: 20.08.1

M  +2    -0    app/browsemainpage.cpp

https://invent.kde.org/graphics/gwenview/commit/5bcfd5b83ca86cebceb9cc08d5dded00ca6819cb
Comment 3 postix 2020-08-25 09:15:28 UTC 
Thank you Nate! :)
Comment 4 Nate Graham 2020-08-25 14:09:53 UTC 
You're welcome!