| Summary: | Plasma crashes in PanelView::restore() when changing settings related to number of screens, screen scale, screen borders, etc | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | mabg |
| Component: | Panel | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | a.samirh78, bugseforuns, danielwohlers, dragonpurpuracolocado, eam0809, gerhard.riener, germanoalves, kde, lostipodman, lukas, nate, oguilherme, plasma-bugs, queny, robert, simon.sylvain13, techxgames |
| Priority: | VHI | Keywords: | drkonqi |
| Version: | 5.19.4 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/fa2bafea8f0cd9fac0864ac23f23c955d5f15b73 | Version Fixed In: | 5.21 |
| Sentry Crash Report: | |||
| Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi |
||
|
Description
mabg
2020-08-23 13:12:38 UTC
Created attachment 131691 [details]
New crash information added by DrKonqi
plasmashell (5.19.5) using Qt 5.15.0
- What I was doing when the application crashed:
I restarted my notebook, because I couldn't connect my already paired bluetooth speakers.
I switched recently from x.org to wayland.
-- Backtrace (Reduced):
#4 0x00007fb055b1bd5f in KConfigGroup::parent (this=this@entry=0x7ffd71cf48f0) at ./src/core/kconfiggroup.cpp:545
#5 0x00005593333ad341 in PanelView::restore (this=this@entry=0x559334876780) at ./shell/panelview.cpp:576
#6 0x00005593333ad762 in PanelView::containmentChanged (this=0x559334876780) at ./shell/panelview.cpp:1179
#7 0x00005593333adbb3 in PanelView::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=0x7ffd71cf4ad0) at ./obj-x86_64-linux-gnu/shell/plasmashell_autogen/include/moc_panelview.cpp:261
#8 0x00007fb0548fb5e0 in doActivate<false> (sender=0x559334876780, signal_index=43, argv=0x7ffd71cf4ad0) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:395
*** Bug 430656 has been marked as a duplicate of this bug. *** *** Bug 430685 has been marked as a duplicate of this bug. *** *** Bug 415884 has been marked as a duplicate of this bug. *** *** Bug 422901 has been marked as a duplicate of this bug. *** *** Bug 427096 has been marked as a duplicate of this bug. *** *** Bug 422637 has been marked as a duplicate of this bug. *** *** Bug 430548 has been marked as a duplicate of this bug. *** *** Bug 428678 has been marked as a duplicate of this bug. *** *** Bug 429240 has been marked as a duplicate of this bug. *** Tons of dupes, raising priority. There is an error path
KConfigGroup PanelView::panelConfig(ShellCorona *corona, Plasma::Containment *containment, QScreen *screen)
{
if (!containment || !screen) {
return KConfigGroup();
}
which we call parent() on. That's obviously going to crash.
.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/553 *** Bug 431280 has been marked as a duplicate of this bug. *** Git commit fa2bafea8f0cd9fac0864ac23f23c955d5f15b73 by David Edmundson.
Committed on 08/01/2021 at 00:23.
Pushed by davidedmundson into branch 'master'.
[panel] Fix crash on screen changes
There is an error handling path when we fetch the relevant config()
```
KConfigGroup PanelView::panelConfig(...
{
if (!containment || !screen) {
return KConfigGroup();
}
```
which we indiscrimiately call parent() on.
This patch guards that case, which is presumably screen being
temporarily null.
This code is also Plasma 5.8 compatibility fallback, so arguably we
could get rid of it.
M +4 -3 shell/panelview.cpp
https://invent.kde.org/plasma/plasma-workspace/commit/fa2bafea8f0cd9fac0864ac23f23c955d5f15b73
*** Bug 432051 has been marked as a duplicate of this bug. *** Created attachment 136063 [details]
New crash information added by DrKonqi
plasmashell (5.21.0) using Qt 5.15.2
Including as on 5.21 and this bug shows as resolved on 5.21; sorry but it is NOT resolved
- What I was doing when the application crashed:
Happens immediately upon login when a monitor is attached and on a Wayland session
- Unusual behavior I noticed:
Seems to affect the fonts (they are not the correct size and they are blurry) in my Application Menu Bar (but not certain the two are related)
- Custom settings of the application:
Monitor is connected via HDMI
-- Backtrace (Reduced):
#4 0x00007f97e66cb452 in QScreen::name (this=0x5649c00fb500) at kernel/qscreen.cpp:195
#5 0x00005649bf1a50df in ShellCorona::addOutput (this=this@entry=0x5649c05e0700, screen=<optimized out>, screen@entry=0x5649c00fb500) at /usr/src/debug/plasma5-workspace-5.21.0-1.1.x86_64/shell/shellcorona.cpp:1248
#6 0x00005649bf1a5d8b in ShellCorona::load (this=<optimized out>) at /usr/src/debug/plasma5-workspace-5.21.0-1.1.x86_64/shell/shellcorona.cpp:698
#7 0x00007f97e6186946 in QtPrivate::QSlotObjectBase::call (a=0x7ffff0eaca00, r=0x5649c05e0700, this=0x5649c03ae010) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#8 doActivate<false> (sender=0x5649c030dac0, signal_index=4, argv=argv@entry=0x7ffff0eaca00) at kernel/qobject.cpp:3886
|