| Summary: | "Run command->Add command" should open global settings window with it`s page specified (and popup) | ||
|---|---|---|---|
| Product: | [Applications] kdeconnect | Reporter: | Maksym Hazevych <dpadar> |
| Component: | android-application | Assignee: | Albert Vaca Cintora <albertvaka> |
| Status: | CONFIRMED --- | ||
| Severity: | minor | CC: | nicolas.fella |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Android 10.x | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | What it should open | ||
Accidentally created issue without proper description. So, here it is: SUMMARY "Run command->Add command" opens KDE Connect Settings in it`s own window. Instead, it should open System Settings on KDE Connect page (with Run Commands popup) - this behavior is now standard when opening concrete settings pages. Also, if, when pressing, you already have KDE Connect opened in System Settings - error "This configuration section is already opened in System Settings" will pop-up. I guess it will not be an issue if opening global window. I agree. I needed to do some preparatory work on systemsettings first tough https://invent.kde.org/plasma/systemsettings/-/merge_requests/11 Git commit 1060c1a81af90aca94aef9aad3267dc3f16089ba by Nicolas Fella. Committed on 18/10/2020 at 18:40. Pushed by nicolasfella into branch 'master'. Add API for opening the KCM to daemon We have a few places that open the KCM, with different arguments. Centralize the implementation in one place. This makes it easier to switch to invoking systemsettings5 in the future (once https://invent.kde.org/plasma/systemsettings/-/merge_requests/11 is in). It also makes sure the relevant device is selected when clicking on a pairing notification. The function is exposed to DBus for the Plasmoid and potential third-party users. M +21 -0 core/daemon.cpp M +2 -0 core/daemon.h M +2 -2 daemon/kdeconnectd.cpp M +1 -2 plasmoid/package/contents/ui/FullRepresentation.qml M +1 -1 plasmoid/package/contents/ui/main.qml M +2 -1 plugins/runcommand/runcommandplugin.cpp https://invent.kde.org/network/kdeconnect-kde/commit/1060c1a81af90aca94aef9aad3267dc3f16089ba |
Created attachment 131086 [details] What it should open SUMMARY "Run command->Add command" open KDE Connect Settings in it`s own window. STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION