Bug 425538

Summary:	on-screen display period broken
Product:	[Applications] systemsettings	Reporter:	Sebastian Kügler <sebas>
Component:	kcm_kwinvirtualdesktops	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, nate, plasma-bugs
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kwin/-/commit/b8580339b44e376dbf035cb7a93096f71319ee54	Version Fixed In:	5.22

Description Sebastian Kügler 2020-08-19 10:42:34 UTC

SUMMARY
Setting the interval to show the desktop switching OSD is broken in multiple ways:

1. inputting a number doesn't enable the Apply button (scrolling to change number seems to work)
2. inputting 1000 (as opposed to 1.000) resets it to zero

I'm using en_US locale.

There are some more pretty basic bugs in there which makes it barely work. Could it be that merging the QtQuick port for this KCM has been rushed a little?

I'm referring to https://bugs.kde.org/show_bug.cgi?id=417751 which I also noticed when re-adding rows after trying if resetting to defaults helped me out here.
Then, while I set rows to two, the display shows three rows (plus above i18n error), filing another bug for this just now.

Linux/KDE Plasma: Neon User 20.04
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.73
Qt Version: 5.14.2

Comment 1 Nate Graham 2021-05-24 19:13:46 UTC

Git commit 5484b846b3869a8adca4cf801ca296b94017179e by Nate Graham, on behalf of David Edmundson.
Committed on 24/05/2021 at 18:51.
Pushed by ngraham into branch 'master'.

[kcmkwin/kwindesktop] Implement valueFromText in a spinbox

If textFromValue is set, valueFromText must be.

A lot of other implemenetations were using parseInt() which fails at
reading "3,000" due to the comma. Qt's fromLocaleString handles that but
needs any text stripping.

This implementation isn't perfect, but really we need to work on a good
upstream solution.

M  +1    -0    src/kcmkwin/kwindesktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/kwin/commit/5484b846b3869a8adca4cf801ca296b94017179e

Comment 2 Nate Graham 2021-05-24 19:13:55 UTC

Git commit b8580339b44e376dbf035cb7a93096f71319ee54 by Nate Graham, on behalf of David Edmundson.
Committed on 24/05/2021 at 19:11.
Pushed by ngraham into branch 'Plasma/5.22'.

[kcmkwin/kwindesktop] Implement valueFromText in a spinbox

If textFromValue is set, valueFromText must be.

A lot of other implemenetations were using parseInt() which fails at
reading "3,000" due to the comma. Qt's fromLocaleString handles that but
needs any text stripping.

This implementation isn't perfect, but really we need to work on a good
upstream solution.


(cherry picked from commit 5484b846b3869a8adca4cf801ca296b94017179e)

M  +1    -0    src/kcmkwin/kwindesktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/kwin/commit/b8580339b44e376dbf035cb7a93096f71319ee54