| Summary: | Contiguous Selection Tool is not working properly | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | Tools/Selection | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, tamtamy.tymona |
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/85b90c1c75de5a03cee657ce1ce8661a3f15c5f7 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Before clicking
After clicking inside selection |
||
|
Description
acc4commissions
2020-08-19 00:18:00 UTC
If you uncheck the 'Use Selection as Boundary' option, it works fine. And contrary to what you mentioned in Bug 418071, it will only paint in the area inside the selection even when I uncheck the option. Created attachment 131237 [details]
Before clicking
Created attachment 131238 [details]
After clicking inside selection
Well, I think it works as expected. "Use selection as boundary" is expected the "flooding" of the selection into areas you don't want. And it does that (see the screenshots). Another thing is that after flooding the current selection it cannot select anything else, that might be a UIX problem... (In reply to Dmitry Kazakov from comment #4) > Well, I think it works as expected. "Use selection as boundary" is expected > the "flooding" of the selection into areas you don't want. And it does that > (see the screenshots). Another thing is that after flooding the current > selection it cannot select anything else, that might be a UIX problem... Oh so does that mean it treats the existing selection as if it's the layer boundary? > Oh so does that mean it treats the existing selection as if it's the layer
> boundary?
Yes, exactly :)
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/482 Git commit b9e829a5b326c0165e3546dbd68fa274dbbc100f by Dmitry Kazakov. Committed on 28/08/2020 at 14:00. Pushed by dkazakov into branch 'krita/4.3'. Make "Use Selection As Boundary" create new selection when clicking outside selection Letting contiguous selection create new selection when clicking outside the current selection will let the user keep this checkbox always on. Default behavior for contiguous selection, when clicked inside existing selection is "do nothing", therefore this checkbox just extends this behavior. M +6 -1 plugins/tools/selectiontools/kis_tool_select_contiguous.cc https://invent.kde.org/graphics/krita/commit/b9e829a5b326c0165e3546dbd68fa274dbbc100f Git commit 85b90c1c75de5a03cee657ce1ce8661a3f15c5f7 by Dmitry Kazakov. Committed on 28/08/2020 at 18:50. Pushed by dkazakov into branch 'master'. Make "Use Selection As Boundary" create new selection when clicking outside selection Letting contiguous selection create new selection when clicking outside the current selection will let the user keep this checkbox always on. Default behavior for contiguous selection, when clicked inside existing selection is "do nothing", therefore this checkbox just extends this behavior. M +6 -1 plugins/tools/selectiontools/kis_tool_select_contiguous.cc https://invent.kde.org/graphics/krita/commit/85b90c1c75de5a03cee657ce1ce8661a3f15c5f7 |