Bug 425504

Summary: PlasmaComponents3.BusyIndicator looks off while rotating when default size is overridden
Product: [Frameworks and Libraries] libplasma Reporter: Nate Graham <nate>
Component: componentsAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: normal CC: plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.73.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.74
Sentry Crash Report:
Attachments: Odd rotation with custom size

Description Nate Graham 2020-08-18 13:49:51 UTC
Created attachment 130969 [details]
Odd rotation with custom size

This component's template defaults to a size of gridUnit * 2. If you override it by setting the width/height or implicitWidth/implicitHeigt properties, is rotates very strangely while active. See attached screen recording.

This issue is seen only with the PC3 version; the PC2 version is fine.
Comment 1 Bug Janitor Service 2020-08-23 03:06:14 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/76
Comment 2 Noah Davis 2020-08-23 22:58:44 UTC
Git commit 3509283d63463ab1fb002ad1d143e4c2157f61c0 by Noah Davis.
Committed on 23/08/2020 at 19:08.
Pushed by ndavis into branch 'master'.

Make PC3 BusyIndicator visuals keep a 1:1 aspect ratio

Updated the tests so that you can see if the aspect ratio is correct.

Made an animated transition for when `control.running` is false.

Removed the code that updates the RotationAnimator when control.running changes since it didn't work.

Set padding to 0 (see comment).

M  +96   -25   src/declarativeimports/plasmacomponents3/BusyIndicator.qml
M  +19   -3    tests/components/busyindicator.qml
M  +19   -1    tests/components/busyindicator3.qml

https://invent.kde.org/frameworks/plasma-framework/commit/3509283d63463ab1fb002ad1d143e4c2157f61c0