Bug 425387

Summary: Location bar autosuggestion broken
Product: [Frameworks and Libraries] frameworks-kio Reporter: Claudio <holo-doc>
Component: URL navigatorAssignee: Noah Davis <noahadvs>
Status: RESOLVED FIXED    
Severity: normal CC: andydecleyre, kde, kdelibs-bugs, nate, noahadvs
Priority: NOR Keywords: regression
Version: 5.73.0   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=420966
Latest Commit: https://invent.kde.org/frameworks/kio/commit/955984a1a3cc8a64d98e6ddfcc09881a4dd7880a Version Fixed In:

Description Claudio 2020-08-15 15:26:37 UTC 
SUMMARY


STEPS TO REPRODUCE
1. Click in the location bar in Dolphin or in an Open/Save dialog
2. Type e.g. '/ho'
3. Press 'TAB' key

OBSERVED RESULT
Instead like in previous Releases (Up to kio 5.72.0) only '/home' instead of '/home/' is auto-completed.
So to navigate to deeper folders i have to manually add a '/' after every auto-complete step.

EXPECTED RESULT
That autosuggestion works as before (you only have to use TAB, arrow keys and the first few letters of a folder), as it also works in Shells like bash and fish (they also add the '/' after tabbed file/folder-name completion).

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0
Kernel Version: 5.8.1-2-MANJARO
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4790K CPU @ 4.00GHz
Memory: 31.3 GiB of RAM
Graphics Processor: Radeon RX 580 Series

ADDITIONAL INFORMATION
Probably introduced with commit:
https://github.com/KDE/kio/commit/9f5f8540112e1178aa54a350f29b542c5de7df68
Comment 1 Nate Graham 2020-08-19 15:58:49 UTC 
Hmm, I recall that this was an intentional change to fix Bug 420966. But the originator doesn't seem like we made the right fix.

Thoughts?
Comment 2 andydecleyre 2020-08-19 16:31:23 UTC 
Please do check over the conversation Nate linked.

While this is broken, I've put kio-append-slash in the AUR, and I recommend to change your completion mode to "Dropdown List" (right click editable location bar).
Comment 3 Noah Davis 2020-09-04 20:03:42 UTC 
Git commit 955984a1a3cc8a64d98e6ddfcc09881a4dd7880a by Noah Davis.
Committed on 04/09/2020 at 19:47.
Pushed by ndavis into branch 'master'.

Revert "[KUrlCompletion] Don't append / to completed folders"

This reverts commit 9f5f8540112e1178aa54a350f29b542c5de7df68.

Revert "Remove / from kurlcompletiontest matches"

This reverts commit b167b61de8c8b4b3f601b741dda9bd70a2fc83d9.

M  +14   -14   autotests/kurlcompletiontest.cpp
M  +1    -1    src/widgets/kurlcompletion.cpp

https://invent.kde.org/frameworks/kio/commit/955984a1a3cc8a64d98e6ddfcc09881a4dd7880a