Bug 425322

Summary:	Can't pick font by writing its name in font name field
Product:	[Applications] krita	Reporter:	kalia24
Component:	Tool/Text	Assignee:	wolthera <griffinvalley>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahab.greybeard, griffinvalley, halla
Priority:	NOR	Keywords:	regression
Version:	4.3.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/krita/commit/2e38c2623b164b2b56b29e96bdae13aa64b1551d	Version Fixed In:
Sentry Crash Report:

Description kalia24 2020-08-13 20:18:53 UTC

SUMMARY
When you start typing font name, the field accepts the first letter (though search doesn't start, no possible results appear in drop-down list nor nearest match in the field itself). When you put in the second letter, it auto-magically choses first font available (alphabetically or from the list of "previously used") and adds that letter at the end of the name, then won't add any more - instead it keeps changing the one added... Or several last if there's more than 2.
Or it doesn't accept any letter at all just fills with last used.
Or it accepts a few letters, then goes nuts.
And of course it saves each "search", so in a second you have the list of "recently used" filled with combos of trash letters (if you just forget it doesn't work and start typing - like I do...).
I'm pretty sure it used to work in some previous version.

STEPS TO REPRODUCE
1. Put in some text and open Text Editor.
2. Try choose a font by typing something in the font name field (f.ex. Times New Roman)

OBSERVED RESULT
Text field contents go nuts. I can't even find a pattern in it.

EXPECTED RESULT
Filed shows nearest match or a drop-down list appears with results containing inserted string.

SOFTWARE/OS VERSIONS
Windows 10

Comment 1 Ahab Greybeard 2020-08-14 11:51:43 UTC

I can confirm this for the Aug13 4.3.1 alpha (git adcd40a) appimage and the 4.3.0. appimage.

The 4.2.9 appimage does not have this problem.
It looks like a regression in 4.3.0.


The only way I can put anything into the font family field is to highlight it and then Ctrl+V paste text into it.

Sometimes, you can backspace the existing text away, letter by letter but then it reverts to the original after a variable number of backspaces.

Overtyping a highlighted entry works for a few characters then it places some previous value on it.
The text that you managed to type is stored as a font name at the top of the font list.

Comment 2 wolthera 2020-08-22 13:04:50 UTC

Git commit 3ecf7a640ba8e9a0209121a910052f035905c747 by Wolthera van Hövell tot Westerflier.
Committed on 22/08/2020 at 13:03.
Pushed by woltherav into branch 'master'.

Fix selecting a font in the font combobox by being less agressive in activating slots.

currentTextChanged is too sensitive for a simple check on whether a new font was chosen.

M  +2    -2    plugins/tools/svgtexttool/kis_font_family_combo_box.cpp

https://invent.kde.org/graphics/krita/commit/3ecf7a640ba8e9a0209121a910052f035905c747

Comment 3 wolthera 2020-08-22 13:05:36 UTC

Git commit 2e38c2623b164b2b56b29e96bdae13aa64b1551d by Wolthera van Hövell tot Westerflier.
Committed on 22/08/2020 at 13:05.
Pushed by woltherav into branch 'krita/4.3'.

Fix selecting a font in the font combobox by being less agressive in activating slots.

currentTextChanged is too sensitive for a simple check on whether a new font was chosen.

M  +2    -2    plugins/tools/svgtexttool/kis_font_family_combo_box.cpp

https://invent.kde.org/graphics/krita/commit/2e38c2623b164b2b56b29e96bdae13aa64b1551d