Bug 425286

Summary: It is possible to D&D frames onto a locked layer
Product: [Applications] krita Reporter: Dmitry Kazakov <dimula73>
Component: AnimationAssignee: Emmet O'Neill <emmetoneill.pdx>
Status: RESOLVED FIXED    
Severity: normal CC: ahab.greybeard, emmetoneill.pdx
Priority: NOR    
Version: 4.3.0   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: https://invent.kde.org/graphics/krita/commit/0de750e3ad19747f0c3583ed8976e84ff89196de Version Fixed In:
Sentry Crash Report:

Description Dmitry Kazakov 2020-08-13 10:42:23 UTC 
SUMMARY
One cannot manipulate frames on a locked layer, that works perfectly fine. But if one **drops** frames from unlocked layer to a locked one, the operation succeeds.

STEPS TO REPRODUCE
1. Create two layers
2. Lock the lower one
3. Try to D&D frames from the unlocked one to the locked one

OBSERVED RESULT

Frames are added to the locked layer

EXPECTED RESULT

Locked portion of frames return to their original positions. Frames from the same selection that managed to land on unlocked layer are moved.
Comment 1 Ahab Greybeard 2020-08-13 18:35:09 UTC 
I can confirm this for the Aug12 4.3.1 alpha (git dbf8a5d) appimage.
Comment 2 Eoin O'Neill 2020-09-02 20:46:38 UTC 
Git commit 8ab41ecb1638394f8b730d93265b5fa592aa9142 by Eoin O'Neill.
Committed on 02/09/2020 at 20:44.
Pushed by eoinoneill into branch 'master'.

Frame Drag and Drop No Longer Accepted on Uneditable Layers

Locked layers and invisible layers cannot accept new keyframe content
when drag and dropping data, which is in line with the rest of the
timeline design.

M  +2    -0    plugins/dockers/animation/timeline_frames_model.cpp

https://invent.kde.org/graphics/krita/commit/8ab41ecb1638394f8b730d93265b5fa592aa9142
Comment 3 Eoin O'Neill 2020-09-02 22:32:39 UTC 
Git commit 0de750e3ad19747f0c3583ed8976e84ff89196de by Eoin O'Neill.
Committed on 02/09/2020 at 22:22.
Pushed by eoinoneill into branch 'krita/4.3'.

Frame Drag and Drop No Longer Accepted on Uneditable Layers

Locked layers and invisible layers cannot accept new keyframe content
when drag and dropping data, which is in line with the rest of the
timeline design.
(cherry picked from commit 8ab41ecb1638394f8b730d93265b5fa592aa9142)

M  +2    -0    plugins/dockers/animation/timeline_frames_model.cpp

https://invent.kde.org/graphics/krita/commit/0de750e3ad19747f0c3583ed8976e84ff89196de