Bug 425219

Summary:	suspicious URL warning system gives false positive for URL with port number
Product:	[Applications] kmail2	Reporter:	Erik Quaeghebeur <bugs.kde.org>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	montel
Priority:	NOR
Version:	5.14.3
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/pim/messagelib/commit/b59b745064145aedbeca3b34768fef975e18867d	Version Fixed In:	5.15.1
Sentry Crash Report:
Attachments:	test case

Description Erik Quaeghebeur 2020-08-11 12:30:04 UTC

KMail gave a warning when a URL in a plain text email contained a port number. It said that

“This email contains a link which reads as 'https://example.com:443/blablabla' in the text, but actually points to 'https://example.com/blablabla'. This is often the case in scam emails to mislead the recipient”

KMail should be a bit smarter here. I actually also think that this kind of warning message is not appropriate for plain text emails in any circumstance. (Other types of URL warnings may be.)

N.B.: Missing period at end of warning.

Comment 1 Laurent Montel 2020-08-31 05:02:34 UTC

Do you have a test case so I can create autotest against it please ?
Regards.

Comment 2 Erik Quaeghebeur 2020-08-31 06:35:48 UTC

Created attachment 131306 [details]
test case

Comment 3 Laurent Montel 2020-08-31 07:09:50 UTC

Thanks
in last version I don't have warning.
Did you success to reproduce it ?

Comment 4 Erik Quaeghebeur 2020-08-31 08:47:41 UTC

(In reply to Laurent Montel from comment #3)
> in last version I don't have warning.
> Did you success to reproduce it ?

I'm still on 20.04.3. I haven't tried 20.08.0 yet. If you don't see it in that version, feel free to close mentioning the exact version for which it was working correctly for you. Once I update to that or beyond, I can check again and reopen if it persists for me.

Comment 5 Laurent Montel 2020-09-01 06:20:52 UTC

Git commit 7f2505d60629a2998518e5cc36e04e4ca6529bda by Laurent Montel.
Committed on 01/09/2020 at 06:20.
Pushed by mlaurent into branch 'release/20.08'.

Fix Bug 425219 - suspicious URL warning system gives false positive for URL with port number

FIXED-IN: 5.15.1

M  +4    -0    messageviewer/src/scamdetection/autotests/scamdetectionwebenginetest.cpp
M  +3    -1    messageviewer/src/scamdetection/scamdetectionwebengine.cpp

https://invent.kde.org/pim/messagelib/commit/7f2505d60629a2998518e5cc36e04e4ca6529bda

Comment 6 Laurent Montel 2020-09-01 06:21:17 UTC

Git commit b59b745064145aedbeca3b34768fef975e18867d by Laurent Montel.
Committed on 01/09/2020 at 06:21.
Pushed by mlaurent into branch 'master'.

Fix Bug 425219 - suspicious URL warning system gives false positive for URL with port number

FIXED-IN: 5.15.1

M  +4    -0    messageviewer/src/scamdetection/autotests/scamdetectionwebenginetest.cpp
M  +3    -1    messageviewer/src/scamdetection/scamdetectionwebengine.cpp

https://invent.kde.org/pim/messagelib/commit/b59b745064145aedbeca3b34768fef975e18867d