Bug 425162

Not entirely sure why everything is split up into separate .so files now? It kills performance (a bit more).

Martin, konsole is not split into multiple .so files, there will not be a performance hit. it's split into multiple static libraries, so it's easier to understand the architecture, and each static library links directly to the libkonsoleprivate.so

I just reverted the commit that broke the build, and that also was a bit of facepalm moment for me:
currently the konsole architecture is broken, as there's a hard dependency on SessionController -> TerminalDisplay, but there's also a hard dependency on TerminalDisplay->SessionController. And this was the cause of the linkage error.

For me, without those flags and gcc 10.1, it compiled fine, so that's the reason I didn't realized sooner.

I meant .a files, it impacts build times a bit. might impact LTO as well, unless we switch to thin archives (which has another bunch of issues).


Alternatively we could do something like this (cmake magic I recently learned), I think that works more like expected (i. e. isn't impacted by LDFLAGS and stuff):

  diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
  index 58b3290f..16fd27af 100644
  --- a/src/CMakeLists.txt
  +++ b/src/CMakeLists.txt
  @@ -205,7 +205,7 @@ ki18n_wrap_ui(konsoleprivate_SRCS
   # add the resource files for the ui files
   qt5_add_resources( konsoleprivate_SRCS ../desktop/konsole.qrc)
   
  -add_library(konsoleprivate ${konsoleprivate_SRCS})
  +add_library(konsoleprivate ${konsoleprivate_SRCS}  $<TARGET_OBJECTS:konsolesession>)
   generate_export_header(konsoleprivate BASE_NAME konsoleprivate)
   
   target_link_libraries(konsoleprivate
  diff --git a/src/session/CMakeLists.txt b/src/session/CMakeLists.txt
  index 1e8f86a2..d4271ab8 100644
  --- a/src/session/CMakeLists.txt
  +++ b/src/session/CMakeLists.txt
  @@ -24,7 +24,7 @@ set(konsole_session_SRCS
   )
   
   add_library(konsolesession
  -    STATIC
  +    OBJECT
       ${konsole_session_SRCS}
   )
   

It makes it harder to depend on other modules (so with this no other modules can depend on konsolesession), but that's really a good thing imho.

But thanks for the quick response!