Bug 424986

Summary:	"New Tab" session menu does not work
Product:	[Applications] konsole	Reporter:	Christoph Feck <cfeck>
Component:	tabbar	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	minor	CC:	justin.zobel, nate, piotr.mierzwinski, tumaix, wbauer1
Priority:	NOR
Version:	master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/utilities/konsole/-/commit/3f2b2d9df4ca74baa0d263c36dc70d95c149b221.patch	Version Fixed In:	20.12.1
Sentry Crash Report:

Description Christoph Feck 2020-08-04 06:00:10 UTC

STEPS TO REPRODUCE
1. Configure Konsole to show 'New Tab' button and at least two profiles
2. Click and hold the New Tab button
3. Select one of the profiles from the menu

OBSERVED RESULT
Nothing happens

EXPECTED RESULT
The selected profile is loaded in a new tab

SOFTWARE/OS VERSIONS
Konsole: git master at 955c6997
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0

ADDITIONAL INFORMATION
This seems to be a recent regression. Just clicking on the New Tab button loads a new tab, but only with the default profile. The New Tab menu from the menubar also works correctly.

Comment 1 Nate Graham 2020-08-10 16:30:43 UTC

I see a slightly different issue: the menu only shows one item in it no matter how many profiles I have.

Comment 2 Nate Graham 2020-08-10 16:32:43 UTC

Oh actually that's because I didn't make sure to check those profiles in the visibility column of the "Manage Profiles" window. When I do that, they all show up in the menu and clicking on one of them works as expected.

This is with today's git master.

Comment 3 Christoph Feck 2020-08-10 19:59:33 UTC

I updated to f4bf8a42 and the issue is still reproducible using the steps from comment 0.

Comment 4 Justin Zobel 2020-11-03 00:54:55 UTC

Confirmed still an issue on git master.

Comment 5 Christoph Feck 2020-12-01 15:58:43 UTC

*** Bug 429870 has been marked as a duplicate of this bug. ***

Comment 6 Kurt Hindenburg 2020-12-02 02:15:46 UTC

Well I can't reproduce - not sure what the difference is.

Comment 7 Piotr Mierzwinski 2020-12-29 22:03:18 UTC

I tested it in version 21.03.70 and seems starting session by described action works. I have 3 profiles and each of one raised.

Comment 8 Christoph Feck 2020-12-30 11:41:06 UTC

Thanks, I can confirm it works now. Feel free to dig up the commit that fixed it.

Comment 9 Wolfgang Bauer 2020-12-30 19:39:46 UTC

It seems to have been fixed by this commit:
https://invent.kde.org/utilities/konsole/-/commit/3f2b2d9df4ca74baa0d263c36dc70d95c149b221.patch

I rebuilt konsole 20.12.0 (where I was able to reproduce the problem) with that patch and it works. (also "Switch Profile" in the context menu, which was broken in the same way)

So it should be fixed in 20.12.1.