| Summary: | Adding "Trash" to Kickoff favorites doesn't work | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Lua <lv215bd5> |
| Component: | Application Launcher (Kickoff) widget | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | christ.derek, kde, mikel5764, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | 5.18.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/86517407195186a18346079bb456a9308bbed836 | Version Fixed In: | 5.25 |
| Sentry Crash Report: | |||
| Attachments: | nothing happens | ||
Sorry, I typed Places instead of Computer. And I also forgot to add the information, aaaargh >< SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: Kubuntu 20.04 (available in About System) KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.68.0 Qt Version: 5.12.8 ADDITIONAL INFORMATION Confirmed. Context menu no longer opens for Trash here in KDE 5.21.4, so the problem was fixed? Nah, still a bug. Understood. I though this feature was removed, making the context behavior not opening intentional The problem seems to be that kastatsfavoritesmodel.cpp does not recognize any of the KIO workers (e.g. trash:/ and desktop:/) as valid things that can be favorited. Git commit 86517407195186a18346079bb456a9308bbed836 by Méven Car. Committed on 03/05/2022 at 12:10. Pushed by meven into branch 'master'. Allow to display any place in favorites, /home/user or trash:/ or sftp:/my-server M +11 -3 applets/kicker/plugin/fileentry.cpp M +1 -1 applets/kicker/plugin/fileentry.h M +24 -11 applets/kicker/plugin/kastatsfavoritesmodel.cpp https://invent.kde.org/plasma/plasma-workspace/commit/86517407195186a18346079bb456a9308bbed836 Not a fan of those blocking mime determination in this patch. This should only be done when adding the place, not every time it's constructed. Unless I'm missing something this would jeopardize Plasma startup, no? |
Created attachment 130599 [details] nothing happens SUMMARY STEPS TO REPRODUCE 1. Open Kickoff, go to Places > scroll to the bottom to find the Trash item. 2. Right click on it > Add to favorites OBSERVED RESULT Nothing happens. EXPECTED RESULT Trash being pinned to Kickoff. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION