Bug 424892

Summary:	Button without icon appears when I hover over a updateable addon in GHNS windows
Product:	[Frameworks and Libraries] frameworks-knewstuff	Reporter:	Patrick Silva <bugseforuns>
Component:	general	Assignee:	Jeremy Whiting <jpwhiting>
Status:	RESOLVED FIXED
Severity:	normal	CC:	admin, kdelibs-bugs-null, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/knewstuff/commit/3b2bf76e3fd2d3ded534ca27ba55ca6887e66df7	Version Fixed/Implemented In:	5.74
Sentry Crash Report:
Attachments:	screenshot

Description Patrick Silva 2020-08-01 12:35:42 UTC

Created attachment 130552 [details]
screenshot

STEPS TO REPRODUCE
1. open a GHNS window when there is a update for some addon
2. click on the second button on top
3. set the second dropdown on bottom to "Updateable only"
3. hover over a updateable addon

OBSERVED RESULT
As we can see in the attached screenshot, a button without icon appears

EXPECTED RESULT
all buttons should have an icon

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.73.0
Qt Version: 5.14.2

Comment 1 Nate Graham 2020-08-01 19:47:20 UTC

Can confirm. Looks trivial-ish to fix.

Comment 2 Nate Graham 2020-08-01 19:51:02 UTC

Git commit 3b2bf76e3fd2d3ded534ca27ba55ca6887e66df7 by Nate Graham.
Committed on 01/08/2020 at 19:50.
Pushed by ngraham into branch 'master'.

[QtQuick dialog] use update icon that exists
FIXED-IN: 5.74

M  +1    -1    src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
M  +1    -1    src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
M  +1    -1    src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

https://invent.kde.org/frameworks/knewstuff/commit/3b2bf76e3fd2d3ded534ca27ba55ca6887e66df7