Bug 424823

Summary: smb4k has Wayland generic icon in window decoration and task switcher
Product: [Applications] Smb4k Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: Alexander Reinholdt <alexander.reinholdt>
Status: RESOLVED FIXED    
Severity: normal CC: afifkamarulimran98, meven.car
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: screenshot

Description Patrick Silva 2020-07-30 12:26:09 UTC
Created attachment 130512 [details]
screenshot

STEPS TO REPRODUCE
1. open smb4k on Wayland session (As we can see in the attached screenshot, window decoration shows the Wayland genecric icon.)
2. press alt+tab and observe the icon that represents smb4k
3. 

OBSERVED RESULT
window decoration and task switcher have Wayland generic icon instead of smb4k icon

EXPECTED RESULT
smb4k icon in window decoration and task switcher

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.73.0
Qt Version: 5.14.2
Comment 1 Afif 2020-08-01 07:54:40 UTC
My situation is somewhat related to this as well, as some of the apps that I am using (Sublime Text, Telegram with Flatpak to name a few) are using the generic Wayland icon.

For X, this is no problem.
Comment 2 Bug Janitor Service 2020-08-03 14:46:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/smb4k/-/merge_requests/2
Comment 3 Méven Car 2020-08-03 14:51:22 UTC
Either those apps don't define an "Icon=" field in there .desktop file or the file is missing /misinstalled or the app does not provide the metadata necessary for Wayland to find the desktop file which is the case for smb4k.

Dave:
Please open a different bug for each app in their respective bug trackers.
Comment 4 Patrick Silva 2020-08-03 14:59:28 UTC
(In reply to Dave from comment #1)
> My situation is somewhat related to this as well, as some of the apps that I
> am using (Sublime Text, Telegram with Flatpak to name a few) are using the
> generic Wayland icon.
> 
> For X, this is no problem.

telegram is supposedly fixed
https://github.com/flathub/org.telegram.desktop/issues/27
Comment 5 Alexander Reinholdt 2020-08-11 07:39:58 UTC
Git commit 980365ffb552e151c891c4c37d36d33f296b6519 by Alexander Reinholdt, on behalf of Méven Car.
Committed on 11/08/2020 at 07:38.
Pushed by areinholdt into branch 'master'.

Fix missing Wayland icon

M  +1    -1    smb4k/icons/hicolor/CMakeLists.txt
M  +1    -1    smb4k/icons/oxygen/CMakeLists.txt
M  +1    -0    smb4k/main.cpp

https://invent.kde.org/network/smb4k/commit/980365ffb552e151c891c4c37d36d33f296b6519