Bug 424666

Summary: Windows de-install deletes shortcuts
Product: [Applications] digikam Reporter: kdeb
Component: Bundle-WindowsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 7.1.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/digikam/commit/ac6b0330466c45fb417bd36d5ff58607b2c0e54f Version Fixed/Implemented In: 7.1.0
Sentry Crash Report:

Description kdeb 2020-07-25 22:09:41 UTC 
The windows de-installer (which is run on update) deletes the digikam start menu folder. Kinda annoying when you put additional shortcuts to digikam specifying different config files in there. 

De-installers really shouldn't delete files they didn't install without at least warning.

STEPS TO REPRODUCE
1. place additional shortcut to digkam in its start menu folder
2. de-install or update
3. 

OBSERVED RESULT
additional short cut is gone

EXPECTED RESULT
additional shortcut should remain. 


SOFTWARE/OS VERSIONS
Windows: 10
Comment 1 Maik Qualmann 2020-07-26 05:43:07 UTC 
The shortcuts are not deleted by the installer. Just like the digiKam configuration file, they are located in the AppData/Local directory.

Maik
Comment 2 Maik Qualmann 2020-07-26 07:30:57 UTC 
I am not sure whether the shortcuts are discarded by the KF5 component when we define or change new ones in the main program. However, you have the option of exporting a shortcut scheme in the shortcut settings. Use this option to save the shortcuts.

Maik
Comment 3 kdeb 2020-07-26 18:05:16 UTC 
The start menu shortcuts for digikam are installed here 

C:\ProgramData\Microsoft\Windows\Start Menu\Programs\digiKam 7.1.0

which is the most convenient location for additional shortcuts specifying alternate configuration files.

The de-installer (which is run by the installer if digikam is already installed) deletes the whole folder including shortcuts it didn't install. 

A work around may be to manually create a user start menu folder 

C:\Users\xuserx\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\digiKam 7.1.0

and place alternate shortcuts there, but. as I said I think it bad form for a de-installer to delete files it didn't install without warning.
Comment 4 Maik Qualmann 2020-07-26 20:46:34 UTC 
I misunderstood, they are talking about the program link.

Maik
Comment 5 Maik Qualmann 2020-07-26 20:51:55 UTC 
Git commit ac6b0330466c45fb417bd36d5ff58607b2c0e54f by Maik Qualmann.
Committed on 26/07/2020 at 20:48.
Pushed by mqualmann into branch 'master'.

do not delete the shortcut folder if it is not empty
FIXED-IN: 7.1.0

M  +2    -1    NEWS
M  +1    -1    project/bundles/mxe/installer/digikam.nsi

https://invent.kde.org/graphics/digikam/commit/ac6b0330466c45fb417bd36d5ff58607b2c0e54f