Bug 424588

Summary:	Adjust profile to imported clip's profile messes timeline clip positions
Product:	[Applications] kdenlive	Reporter:	Fernando M. Muniz <fernandommuniz>
Component:	Timeline & Editing	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	CONFIRMED ---
Severity:	major	CC:	berndmj, fritzibaby, josh.chandra, julius.kuenzel
Priority:	NOR	Keywords:	triaged
Version First Reported In:	24.08.2
Target Milestone:	---
Platform:	Flatpak
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Glitch still present in version 22.04.2

Description Fernando M. Muniz 2020-07-23 21:38:11 UTC

SUMMARY


STEPS TO REPRODUCE
1. Drag a video from your desktop to Kdenlive's editing timeline with a different video profile (Resolution and framerate)
2. Do any simple editing
3. Accept Kdenlive's message to change the profile to adapt to the video you're now editing

OBSERVED RESULT
The video's order changes completely and you lose hours of editing if you don't click on the message before dragging the video to the timeline

EXPECTED RESULT
Change the resolution and framerate to adapt to the new video, without altering anything i've edited

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 emohr 2020-08-07 15:45:15 UTC

Please try with the Kdenlive_Nightly_Appimage
https://binary-factory.kde.org/job/Kdenlive_Nightly_Appimage_Build/lastSuccessfulBuild/artifact/ 

WARNING: This version has a new project type that is not backwards compatible... so you won't be able to use older versions to open new files.

Comment 2 Fernando M. Muniz 2020-08-07 19:30:35 UTC

(In reply to emohr from comment #1)
> Please try with the Kdenlive_Nightly_Appimage
> https://binary-factory.kde.org/job/Kdenlive_Nightly_Appimage_Build/
> lastSuccessfulBuild/artifact/ 
> 
> WARNING: This version has a new project type that is not backwards
> compatible... so you won't be able to use older versions to open new files.

Tried on Version 20.11.70, it still changes the video's order

Comment 3 emohr 2020-08-08 07:41:42 UTC

I see the point. It's mainly a FPS issue. Steps to reproduce: 
- new project with 720p25 -
- add 1 clip with 1080p50 -
- ignore "switch to clip profile" 
- adjust in/out point of the clip in the timeline 
- now click "switch to clip profile". 

Kdenlive play now with 50fps. The clip in the timeline is still as long as for 25fps. Consequently you see only the first 50% the length of the clip now.

To solve this you have to move each end of the clip and make all clips double as long. 

We should better guide the user what it means "switch to clip profile". 

Do you mean that with "change the video order"?

Comment 4 Fernando M. Muniz 2020-08-08 15:55:42 UTC

(In reply to emohr from comment #3)
> I see the point. It's mainly a FPS issue. Steps to reproduce: 
> - new project with 720p25 -
> - add 1 clip with 1080p50 -
> - ignore "switch to clip profile" 
> - adjust in/out point of the clip in the timeline 
> - now click "switch to clip profile". 
> 
> Kdenlive play now with 50fps. The clip in the timeline is still as long as
> for 25fps. Consequently you see only the first 50% the length of the clip
> now.
> 
> To solve this you have to move each end of the clip and make all clips
> double as long. 
> 
> We should better guide the user what it means "switch to clip profile". 
> 
> Do you mean that with "change the video order"?

By "changing the video's order" i was referring to the problem it causes.

Comment 5 Josh Chandra 2021-02-16 09:16:06 UTC

I have this same problem, too, and really came here to ask if immediate profile-switching could be automatically done by default, to solve this issue.

Comment 6 Fernando M. Muniz 2021-04-08 21:12:26 UTC

(In reply to Josh Chandra from comment #5)
> I have this same problem, too, and really came here to ask if immediate
> profile-switching could be automatically done by default, to solve this
> issue.

Maybe it would be better if it switched automatically and the message would be asking to go back to the default that was before the clip was put in the timeline.

Comment 7 Fernando M. Muniz 2022-06-20 10:32:27 UTC

Created attachment 149948 [details]
Glitch still present in version 22.04.2

Since my explanation wasn't great, here's a video showing the glitch in version 22.04.2

Comment 8 Josh Chandra 2022-06-20 14:00:06 UTC

(In reply to Fernando M. Muniz from comment #6)
> 
> Maybe it would be better if it switched automatically and the message would
> be asking to go back to the default that was before the clip was put in the
> timeline.

That would be perfect!!! Great idea!!

Comment 9 Fernando M. Muniz 2023-06-25 13:22:18 UTC

This glitch wasn't fixed.

Comment 10 Bernd 2024-08-05 17:50:54 UTC

(In reply to Josh Chandra from comment #8)
> (In reply to Fernando M. Muniz from comment #6)
> > 
> > Maybe it would be better if it switched automatically and the message would
> > be asking to go back to the default that was before the clip was put in the
> > timeline.
> 
> That would be perfect!!! Great idea!!

I am not sure, honestly. I find it very dangerous to change project settings, in particular fps. This messes with keyframes or speed change or time remap settings. It is ok to have Kdenlive ask to change the settings when the first video file is added to the bin and has differing settings. But only then should a switch be possible. Any asset added later must conform to the settings in order to avoid messing up the project. I could see that a warning message could be displayed that informs the user that accepting the changes to the project settings can cause issues. Still, I would recommend against it.