Bug 424542

Summary:	Inline text annotation: “Current annotation has no fill color”
Product:	[Applications] okular	Reporter:	Laura David Hurka <laura.stern>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	CONFIRMED ---
Severity:	minor	CC:	postix, simgunz
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Laura David Hurka 2020-07-22 15:58:06 UTC

SUMMARY
The color of inline annotations is defined by the stroke color button (with a stroke color icon), not by the fill color button, which makes not much sense to me. The fill color button (with a fill color icon) then says “Current annotation has no fill color”.

STEPS TO REPRODUCE
1. Open a document.
2. Select Inline Note annotation tool.

OBSERVED RESULT
Stroke color button enabled, but defines the fill color.

EXPECTED RESULT
Fill color button enabled.

Comment 1 Simone Gaiarin 2020-07-24 19:25:48 UTC

I think that, if possible, this should be changed at the level of PageViewAnnotator, so that inline note stores its color in the attribute `innerColor` instead of `color`.

In a previous version of the annotation toolbar implemented a logic in annotationactionhandler in order to map the stroke color button to color only for inline note, but than I dropped it because it was a bit of a mess.