Bug 424403

Summary:	"No limit" in local preview size limit actually means "No previews"
Product:	[Applications] dolphin	Reporter:	Antonio Rojas <arojas>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, kfm-devel, nate
Priority:	NOR
Version:	20.07.80
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/system/dolphin/commit/48158d7079cd5f727eade27aa516d8f3133abca2	Version Fixed In:
Sentry Crash Report:

Description Antonio Rojas 2020-07-19 11:07:39 UTC

SUMMARY

In the new spinbox to set the size limit for local size previews, the 0 value says "No limit". But if you set it, it writes MaximumSize=0 to the config, which effectively means no previews at all. 

This causes eg. bug 424367

Comment 1 Patrick Silva 2020-07-19 12:06:44 UTC

On my system only thumbnails of some file types (jpg and png) placed on desktop stop working when I set "No limit" in Dolphin settings. Thumbnails of mp4 video files placed on desktop are generated. Dolphin continues to generate thumbnails of all file types as expected.

SOFTWARE/OS VERSIONS
Dolphin 20.07.80
Operating System: Arch Linux
KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0

Comment 2 Antonio Rojas 2020-07-19 12:15:03 UTC

So dolphin interprets MaximumSize=0 as "no limit", but KIO's PreviewJob doesn't. This should be made consistent.

Comment 3 Bug Janitor Service 2020-08-01 16:50:02 UTC

A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/42

Comment 4 Antonio Rojas 2020-08-02 16:45:44 UTC

Git commit 48158d7079cd5f727eade27aa516d8f3133abca2 by Antonio Rojas.
Committed on 02/08/2020 at 16:45.
Pushed by arojas into branch 'release/20.08'.

Remove MaximumSize entry from kdeglobals when settings the preview file size limit to "No limit"

Instead of setting it to 0, which KIO's PreviewJob interprets as "No previews", breaking previews in konsole and Plasma desktop

M  +8    -4    src/settings/general/previewssettingspage.cpp

https://invent.kde.org/system/dolphin/commit/48158d7079cd5f727eade27aa516d8f3133abca2