Bug 424352

Summary: kparts/part.h: Mismatch between conditions for definition and use of PartSelectEvent
Product: [Frameworks and Libraries] frameworks-kparts Reporter: Bernhard Rosenkränzer <bero>
Component: generalAssignee: David Faure <faure>
Status: RESOLVED WORKSFORME    
Severity: normal CC: a.samirh78, kdelibs-bugs-null
Priority: NOR    
Version First Reported In: 5.72.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Bernhard Rosenkränzer 2020-07-17 22:29:07 UTC
SUMMARY
In <kparts/part.h> from KParts 5.72.0, class PartSelectEvent is declared if KPARTS_ENABLE_DEPRECATED_SINCE(5,72) is set [line 42], but used if KPARTS_BUILD_DEPRECATED_SINCE(5,72) is set [line 227].

This causes build failures (use of undefined type) if KPARTS_BUILD_DEPRECATED... is set, but KPARTS_ENABLE_DEPRECATED... is not.


STEPS TO REPRODUCE
1. Install frameworks 5.72.0
2. Build something that sets BUILD but not ENABLED, such as kontactinterface from release-service 20.07.80

OBSERVED RESULT
/usr/include/KF5/KParts/kparts/part.h:227:34: error: unknown type name 'PartSelectEvent'
    virtual void partSelectEvent(PartSelectEvent *event);


EXPECTED RESULT
Compiles

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: OpenMandriva Cooker
KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0

ADDITIONAL INFORMATION
Comment 1 Ahmad Samir 2021-08-25 11:36:12 UTC
Looks like a configuration issue; feel free to reopen if you still have this issue.