| Summary: | Move contents of "Actions" sub-menu into root level of contextual menu | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | medin <med.medin.2014> |
| Component: | general | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | kfm-devel, nate |
| Priority: | NOR | ||
| Version: | 20.04.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/a82d5712403de7817833b59d8089dfeea91a07b2 | Version Fixed In: | 5.73 |
| Sentry Crash Report: | |||
|
Description
medin
2020-07-16 10:48:26 UTC
> The frequency of use of "Open Terminal here" command is higher than other actions like Archive, Decrypt...
Is it? Evidently it is for you, but can you say that this is the case for everyone?
Furthermore, this isn't easily doable at the moment since the "Open Terminal here" action is actually a plugin provided by Konsole. Uninstall Konsole and you'll see that it disappears. All plugin-provided actions are put under this "Actions" sub-menu. The only way we could move it out is if we move *all* plugin actions to the root level of the menu rather than in a sub-menu. I could actually see the logic behind doing this, but it would have the potential to make the context menu very long.
Thoughts?
(In reply to Nate Graham from comment #1) > > The frequency of use of "Open Terminal here" command is higher than other actions like Archive, Decrypt... > Is it? Evidently it is for you, but can you say that this is the case for > everyone? > > Furthermore, this isn't easily doable at the moment since the "Open Terminal > here" action is actually a plugin provided by Konsole. Uninstall Konsole and > you'll see that it disappears. All plugin-provided actions are put under > this "Actions" sub-menu. The only way we could move it out is if we move > *all* plugin actions to the root level of the menu rather than in a > sub-menu. I could actually see the logic behind doing this, but it would > have the potential to make the context menu very long. > > Thoughts? Thanks, if it's difficult then let's keep what we have and don't bother with my suggestion, I'm just a new average KDE user, in fact I was used to easily find Open Terminal in the root of contextual menu with Mate and Caja through a plugin added to Caja. But for KDE I see that it's controlled from Konsole, so lets keep it like that. Thanks for you hard work :) You're welcome! Moving the actions to the root level of the menu isn't a bad idea, I'm just wondering out loud if it might have the potential to make the context menu too tall. On mine, there are only two items though. Maybe just increase the threshold in https://invent.kde.org/frameworks/kio/-/blob/master/src/widgets/kfileitemactions.cpp#L426 My suggestion would be to allow 3 action items inline, with more then 3 causing the submenu. Would you look at that. Great idea Christoph! I had no idea it already had this feature. I agree that 3 is a better number than one. See https://invent.kde.org/frameworks/kio/-/merge_requests/83. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/83 Keep up, Bug Janitor Service... Git commit a82d5712403de7817833b59d8089dfeea91a07b2 by Nate Graham. Committed on 18/07/2020 at 14:10. Pushed by ngraham into branch 'master'. Show up to three file item actions inline, not just one Right now when there is more than one file item action, all of them get dumped into a sub-menu. Because both Konsole and Gwenview install plugins, and most Plasma installations include these apps, most users experience the file item action plugins in sub-menu form. Using a sub-menu when there is more than one item feels a bit excessive. Showing up to three inline should avoid bloating the menu too much while still handling the rare cases when there are tons and tons of items FIXED-IN: 5.73 M +2 -2 src/widgets/kfileitemactions.cpp https://invent.kde.org/frameworks/kio/commit/a82d5712403de7817833b59d8089dfeea91a07b2 |