Bug 424112

Summary: Cannot run commands anymore
Product: [Plasma] khotkeys Reporter: Kai Uwe Broulik <kde>
Component: generalAssignee: Martin Sandsmark <martin.sandsmark>
Status: RESOLVED FIXED    
Severity: normal CC: kde, kde, kde, lamarque, martin.sandsmark, nate, sepamou
Priority: VHI Keywords: regression
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:

Description Kai Uwe Broulik 2020-07-11 22:02:19 UTC
SUMMARY
After 1d60f46f0fce96731b1df59f59def9ae5ec7a9c6 I cannot run commands anymore. `new KRun` expects a URL but khotkeys let you enter e.g. "dolphin" and run that. Now I just get "invalid URL 'dolphin'"

STEPS TO REPRODUCE
1. Have an action with CommandURL=dolphin
2. Hit shortcut to trigger it

OBSERVED RESULT
An error "invalid url 'dolphin'" appears

EXPECTED RESULT
Dolphin opens

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE git of everything as of today
Comment 1 Nate Graham 2020-07-12 14:16:24 UTC
*** Bug 424117 has been marked as a duplicate of this bug. ***
Comment 2 Lamarque V. Souza 2020-07-14 22:50:29 UTC
I am also affected by this change.
Comment 3 Nate Graham 2020-07-15 02:51:52 UTC
Looks like it may have been caused by https://invent.kde.org/plasma/khotkeys/-/commit/1d60f46f0fce96731b1df59f59def9ae5ec7a9c6#note_74558.

Can you investigate, Martin? Thanks!
Comment 4 Lamarque V. Souza 2020-07-21 11:57:23 UTC
*** Bug 424390 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2020-07-21 17:53:23 UTC
Git commit 8ba8a29c0b357ce5645116d61f051373c6c22be2 by Nate Graham.
Committed on 21/07/2020 at 17:52.
Pushed by ngraham into branch 'master'.

Revert "let KRun do its job in peace"

This reverts commit 1d60f46f0fce96731b1df59f59def9ae5ec7a9c6.

It caused https://bugs.kde.org/show_bug.cgi?id=424112
CCMAIL: martin.sandsmark@kde.org

M  +2    -0    CMakeLists.txt
M  +1    -0    app/CMakeLists.txt
M  +1    -0    libkhotkeysprivate/CMakeLists.txt
M  +62   -2    libkhotkeysprivate/actions/command_url_action.cpp
M  +1    -0    test/CMakeLists.txt

https://invent.kde.org/plasma/khotkeys/commit/8ba8a29c0b357ce5645116d61f051373c6c22be2