Bug 424001

Summary:	canvas update issue (artefacts)
Product:	[Applications] krita	Reporter:	Bollebib <kwadraatnope>
Component:	OpenGL Canvas	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahab.greybeard, dimula73
Priority:	NOR
Version First Reported In:	4.3.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/krita/commit/5b82502e7b959abb5d100371013c5fc834fe3e92	Version Fixed/Implemented In:
Sentry Crash Report:

Description Bollebib 2020-07-08 16:10:58 UTC

1) have one layer visible, one layer invisible
2) use isolate layer on invisible layer (layer is now isolated and should be visible
3)choose the visible layer (now this one will be visible)
4)deactivate isolate layer (now both will be visible)


this should not happen.

The invisible layer should remain invisible

the only way of getting rid of this artefact is toggling the visibility of the invisible layer.

Comment 1 Ahab Greybeard 2020-07-24 16:55:19 UTC

I can confirm this for the Jul 23 5.0.0 prealpha (git c60995a)

Comment 2 Bollebib 2020-07-26 09:09:03 UTC

This Issue also seems to have effect on onion skins not updating immediatly

Comment 3 Bollebib 2020-11-05 15:46:57 UTC

this is still happening in the latest version

Comment 4 Dmitry Kazakov 2020-12-11 12:56:29 UTC

Git commit 2db646c016bc68cbafef202a9662a518738833fa by Dmitry Kazakov.
Committed on 11/12/2020 at 12:56.
Pushed by dkazakov into branch 'krita/4.3'.

Fix artifacts when exiting isolated mode after visiting a hidden layer

Visiting a hidden layer in isolated mode will pollute the parent's
projection. Therefore, we should update the projection not only on
the final exit from the isolated mode, but also on every root switch
that brings in/out a hidden layer into the layer stack.

M  +27   -13   libs/image/kis_image.cc

https://invent.kde.org/graphics/krita/commit/2db646c016bc68cbafef202a9662a518738833fa

Comment 5 Dmitry Kazakov 2020-12-11 13:05:03 UTC

Git commit 5b82502e7b959abb5d100371013c5fc834fe3e92 by Dmitry Kazakov.
Committed on 11/12/2020 at 13:03.
Pushed by dkazakov into branch 'master'.

Fix artifacts when exiting isolated mode after visiting a hidden layer

Visiting a hidden layer in isolated mode will pollute the parent's
projection. Therefore, we should update the projection not only on
the final exit from the isolated mode, but also on every root switch
that brings in/out a hidden layer into the layer stack.

# Conflicts:
#	libs/image/kis_image.cc

M  +27   -13   libs/image/kis_image.cc

https://invent.kde.org/graphics/krita/commit/5b82502e7b959abb5d100371013c5fc834fe3e92