Bug 423853

Summary:	Fill with opacity actions (both FG & BG), do not yield the specified opacity
Product:	[Applications] krita	Reporter:	elkmug <elkmug>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahab.greybeard, griffinvalley
Priority:	NOR
Version First Reported In:	4.3.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description elkmug 2020-07-03 20:33:46 UTC

SUMMARY
The actions 'Fill with Foreground Color (Opacity)' and 'Fill with Background Color (Opacity)' do not yield the specified opacity.

STEPS TO REPRODUCE

1. Select the the Quick Brush: Basic-1, make it's size fairly large so it will be easy to sample. set it's opacity to 50% and draw a stroke on an empty transparent layer.
 
2. Use the Eyedropper tool set to 'Sample Current Layer' and sample the stroke. As expected it's alpha will be roughly 50% (49.8039%)
 
3. Make a selection on an empty part of the same layer. Make sure your opacity is set to 50%, each tool remembers it's opacity independently. Invoke Fill with Foreground Color (Opacity); it's default shortcut is Ctrl+Shift+Backspace. 

OBSERVED RESULT

Use the eyedropper to sample the fill. Note the alpha is 24.7059%


EXPECTED RESULT

The alpha should be roughly 50% (49.8039%)


The issue also effects these actions in eraser mode

1. On a transparent layer, make a selection in an empty area, and fill it with a 100% opaque color.

2. Press the 'e' key to toggle on eraser mode, set tool opacity to 50%

3. Invoke one of the fill with opacity actions.

4. Use the Eyedropper tool set to 'Sample Current Layer' to sample the result
and you will get an alpha of 75.2941%. Expected result: a sampled alpha of roughly 50%


SOFTWARE/OS VERSIONS
Windows: Windows 7, SP 1
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Ahab Greybeard 2020-07-07 14:53:49 UTC

I can confirm this for the 4.3.0 appimage and the Jul 06 4.3.1 alpha (git d3da61) appimage.

It only happens with the Edit -> Fill Special item, not with the Fill Tool directly.

The Jul 06 5.0.0 prealpha (git 193770b) appimage has different behaviour as follows:
On first start, with a new image, the 'Fill with Foreground Color (Opacity)' gives 100% opacity fill. After that, for further layers and further new images, it gives about 25% opacity fills.

Comment 2 wolthera 2020-08-08 19:38:44 UTC

I think this got fixed here: https://invent.kde.org/graphics/krita/-/commit/b869b46d88ff952124a189c7cd4f513f62d7222e

can you check the next krita:plus to see if this is the case?

Comment 3 elkmug 2020-08-08 23:04:24 UTC

(In reply to wolthera from comment #2)

Tested with Krita Stable Windows Build #831 
(krita-nightly-x64-v4.3.0-beta2-507-gaa84881e40) 
and can happily confirm this does fix the the issue :)

Do I need mark this as 'resolved' or does that happen on the developer side?

Comment 4 Bug Janitor Service 2020-08-09 04:33:09 UTC

Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

Comment 5 Ahab Greybeard 2020-08-09 06:52:44 UTC

Anybody can do it :)
Tested with the Aug 08 4.3.1-alpha (git 4667f61) appimage