| Summary: | Port from units.[spacing value] to PlasmaCore.Units.[spacing value] everywhere | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | BingMyBong <bingmybong> |
| Component: | general | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fabian, nate, plasma-bugs |
| Priority: | NOR | ||
| Version First Reported In: | 5.19.2 | ||
| Target Milestone: | 1.0 | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 5.21 | |
| Sentry Crash Report: | |||
| Attachments: | Journal output | ||
Those errors happen when sddm-greeter shuts down. It's just that the Kirigami.Units Singleton is destructed before its users, so it turns into null. This is harmless and you can just ignore this. It happens with git master too. I guess that it should just use "Units.foo" instead of "units.foo" to refer to the Singleton explicitly instead of via its id and also import org.kde.kirigami. At least that seems to avoid the issue here. No need to import Kirigami since there's a Plasma version, which would be PlasmaCore.Units.gridUnit, right? (In reply to Nate Graham from comment #2) > No need to import Kirigami since there's a Plasma version, which would be > PlasmaCore.Units.gridUnit, right? Looks like it, yep. Currently it uses kirigami units, can that cause different behaviour? They should be the same visually, but it's more semantically correct to use PlasmaCore Units in Plasma shell UIs, and Kirigami Units in Desktop/app UIs. Work started with https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/42 This has been done for Plasma 5.21 now. |
Created attachment 129841 [details] Journal output SUMMARY Journal filling up with SDDM-greeter errors related to Breeze that shouldn't be there STEPS TO REPRODUCE 1. Login 2. Logout 3. OBSERVED RESULT Small section from journal (via journalctl) Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/share/sddm/themes/breeze-openSUSE/Main.qml:463: TypeError: Cannot read property 'smallSpacing' of null Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/lib64/qt5/qml/org/kde/plasma/workspace/components/BatteryIcon.qml:42: TypeError: Cannot call method 'roundToIconSize' of null Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/share/sddm/themes/breeze-openSUSE/components/Battery.qml:27: TypeError: Cannot read property 'smallSpacing' of null Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/share/sddm/themes/breeze-openSUSE/Main.qml:441: TypeError: Cannot read property 'largeSpacing' of null Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/share/sddm/themes/breeze-openSUSE/Main.qml:446: TypeError: Cannot read property 'gridUnit' of null Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/share/sddm/themes/breeze-openSUSE/Main.qml:157: TypeError: Cannot read property 'gridUnit' of null Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/share/sddm/themes/breeze-openSUSE/components/ActionButton.qml:102: TypeError: Cannot read property 'smallSpacing' of null Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/share/sddm/themes/breeze-openSUSE/components/ActionButton.qml:39: TypeError: Cannot read property 'gridUnit' of null Jul 01 09:55:11 LanL sddm-greeter[12108]: file:///usr/share/sddm/themes/breeze-openSUSE/components/ActionButton.qml:55: TypeError: Cannot read property 'smallSpacing' of null EXPECTED RESULT No errors in journal I've attached a bigger list of journal errors that includes the example above. I do have a lot more errors in this small file than there should be. SOFTWARE/OS VERSIONS opensuse:tumbleweed:20200622 Qt: 5.15.0 KDE Frameworks: 5.71.0 - KDE Plasma: 5.19.1 - kwin 5.19.1 kmail2 5.14.2 (20.04.2) - akonadiserver 5.14.2 (20.04.2) - Kernel: 5.7.2-1-default - xf86-video-nouveau: 1.0.16