Bug 423772

Summary:	Depends on kdelibs4support for LanguageListModel
Product:	[Applications] lokalize	Reporter:	Albert Astals Cid <aacid>
Component:	general	Assignee:	Simon Depiets <sdepiets>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jr, shafff, sitter
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	dpkg -L kconfigwidgets-data on neon

Description Albert Astals Cid 2020-07-01 21:34:53 UTC

LanguageListModel reads the kf5_all_languages that is provided by kdelibs4support.

Would be nice if we could drop that soft dependency. 

KLanguageButton in kconfigwidgets reads kf5_entry.desktop maybe we can use a similar pattern?

Comment 1 Simon Depiets 2020-07-08 07:38:47 UTC

Created attachment 129969 [details]
dpkg -L kconfigwidgets-data on neon

Comment 2 Simon Depiets 2020-07-08 07:42:18 UTC

On neon libkf5configwidgets-data only installs the en_US/kf5_entry.desktop which contains only the localized version of "American English".

Debian seems to install all of them so is it only a neon packaging issue?
https://packages.debian.org/bullseye/all/libkf5configwidgets-data/filelist

Comment 3 Simon Depiets 2020-07-08 10:52:03 UTC

KLanguageName::nameForCode that you recommended for handling languages from non existing qlocales (for instance brazilian portuguese) fails on neon for the same reason.

Comment 4 Albert Astals Cid 2020-07-08 18:24:31 UTC

Yeah that's Neon just being buggy.

Harald, Jonathan, can you please check why you're not including the rest of kf5_entry.desktop files in kconfigwidget?

Comment 5 Harald Sitter 2020-07-09 09:53:04 UTC

Bug in the injecting them into the git builds I'm guessing.

The files are in the user edition (tarball builds) apparently.

Comment 6 Albert Astals Cid 2020-07-09 18:06:24 UTC

Ok, but don't steal the bug ;)

This is a valid Lokalize bug "unrelated" to the releaseme bug.

I'll file a new one for releaseme.

Comment 7 Simon Depiets 2020-07-26 06:46:12 UTC

I've put a PR for this as I'm not 100% confident I won't break something in another language. This should also improve the flexibility for languages that have no QLocale (Brazil Portuguese).
https://invent.kde.org/sdk/lokalize/-/merge_requests/2

Comment 8 Albert Astals Cid 2020-12-07 22:04:23 UTC

This got fixed by a263c32a5761c28e717d47bb33945d09224ed597