Bug 423670

Summary:	Android: Krita crashes when saving a Krita document with a File Layer
Product:	[Applications] krita	Reporter:	AppTest <xeses16388>
Component:	Layers/Vector	Assignee:	sh_zam <shzam>
Status:	RESOLVED FIXED
Severity:	normal	CC:	shzam
Priority:	NOR
Version:	4.3.0
Target Milestone:	---
Platform:	Android
OS:	Android 10.x
Latest Commit:	https://invent.kde.org/graphics/krita/commit/8fd4bee9648113321bcdd65ce06c190a224caab3	Version Fixed In:
Sentry Crash Report:

Description AppTest 2020-06-29 21:00:32 UTC

SUMMARY
Krita crashes when saving a Krita document with a File Layer

STEPS TO REPRODUCE
1. Create a file layer.
2. Save as Krita document


OBSERVED RESULT
Krita crashes.

EXPECTED RESULT
The Krita document successfully saves.

SOFTWARE/OS VERSIONS
Android build based on 4.3.0 stable

Comment 1 sh_zam 2020-07-02 18:54:53 UTC

Yes, can confirm, thanks!

Comment 2 sh_zam 2020-09-25 10:22:36 UTC

Git commit 1fbe9652548e5eaf5bc195efb6bd0c0de9e131bf by Sharaf Zaman.
Committed on 25/09/2020 at 10:20.
Pushed by szaman into branch 'krita/4.3'.

Android: Use Storage Access Framework for all file operations
Related: bug 424541

A  +973  -0    3rdparty/ext_qt/0047-platform-android-Add-native-file-dialog.patch
A  +165  -0    3rdparty/ext_qt/0048-Android-Properly-close-the-File-Descriptor.patch
A  +171  -0    3rdparty/ext_qt/0049-Android-Workarounds-to-explicitly-handle-content-URI.patch
M  +8    -0    3rdparty/ext_qt/CMakeLists.txt
M  +21   -0    libs/koplugin/KisMimeDatabase.cpp
M  +30   -0    libs/ui/KisAndroidFileManager.cpp
M  +5    -1    libs/ui/KisAndroidFileManager.h
M  +0    -4    libs/ui/KisDocument.cpp
M  +0    -6    libs/ui/KisMainWindow.cpp
M  +3    -0    libs/ui/dialogs/kis_dlg_preferences.cc
M  +10   -0    libs/widgetutils/KoFileDialog.cpp

https://invent.kde.org/graphics/krita/commit/1fbe9652548e5eaf5bc195efb6bd0c0de9e131bf

Comment 3 sh_zam 2020-09-25 10:29:41 UTC

Git commit cd48cc01a36693aa831d857e3a89227c2e9abeee by Sharaf Zaman.
Committed on 25/09/2020 at 10:27.
Pushed by szaman into branch 'master'.

Android: Use Storage Access Framework for all file operations
Related: bug 424541

(cherry-picked from 1fbe9652548e5eaf5bc195efb6bd0c0de9e131bf)

# Conflicts:
#	libs/ui/KisMainWindow.cpp

A  +973  -0    3rdparty/ext_qt/0047-platform-android-Add-native-file-dialog.patch
A  +165  -0    3rdparty/ext_qt/0048-Android-Properly-close-the-File-Descriptor.patch
A  +171  -0    3rdparty/ext_qt/0049-Android-Workarounds-to-explicitly-handle-content-URI.patch
M  +8    -0    3rdparty/ext_qt/CMakeLists.txt
M  +21   -0    libs/koplugin/KisMimeDatabase.cpp
M  +30   -0    libs/ui/KisAndroidFileManager.cpp
M  +5    -1    libs/ui/KisAndroidFileManager.h
M  +0    -4    libs/ui/KisDocument.cpp
M  +0    -6    libs/ui/KisMainWindow.cpp
M  +3    -0    libs/ui/dialogs/kis_dlg_preferences.cc
M  +10   -0    libs/widgetutils/KoFileDialog.cpp

https://invent.kde.org/graphics/krita/commit/cd48cc01a36693aa831d857e3a89227c2e9abeee

Comment 4 Dmitry Kazakov 2020-09-28 06:51:10 UTC

Git commit 8fd4bee9648113321bcdd65ce06c190a224caab3 by Dmitry Kazakov, on behalf of Sharaf Zaman.
Committed on 28/09/2020 at 06:48.
Pushed by dkazakov into branch 'krita/4.4.0'.

Android: Use Storage Access Framework for all file operations
Related: bug 424541

A  +973  -0    3rdparty/ext_qt/0047-platform-android-Add-native-file-dialog.patch
A  +165  -0    3rdparty/ext_qt/0048-Android-Properly-close-the-File-Descriptor.patch
A  +171  -0    3rdparty/ext_qt/0049-Android-Workarounds-to-explicitly-handle-content-URI.patch
M  +8    -0    3rdparty/ext_qt/CMakeLists.txt
M  +21   -0    libs/koplugin/KisMimeDatabase.cpp
M  +30   -0    libs/ui/KisAndroidFileManager.cpp
M  +5    -1    libs/ui/KisAndroidFileManager.h
M  +0    -4    libs/ui/KisDocument.cpp
M  +0    -6    libs/ui/KisMainWindow.cpp
M  +3    -0    libs/ui/dialogs/kis_dlg_preferences.cc
M  +10   -0    libs/widgetutils/KoFileDialog.cpp

https://invent.kde.org/graphics/krita/commit/8fd4bee9648113321bcdd65ce06c190a224caab3