Bug 423653

Summary:	Menu separator too large
Product:	[Frameworks and Libraries] frameworks-qqc2-desktop-style	Reporter:	Nicolas Fella <nicolas.fella>
Component:	general	Assignee:	Nate Graham <nate>
Status:	RESOLVED FIXED
Severity:	normal	CC:	a.stippich, ahiemstra, kde, nate
Priority:	NOR
Version:	5.71.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/qqc2-desktop-style/commit/41e20ee53c690fb6efeab2a40feb917d889ac624	Version Fixed In:	5.73
Sentry Crash Report:
Attachments:	comparison In application

Description Nicolas Fella 2020-06-29 12:12:12 UTC

SUMMARY
The menu separator is too high

This warning seems related:
file:///home/nico/kde/usr/qml/org/kde/kirigami.2/private/ActionsMenu.qml:19:43: QML MenuSeparator: Binding loop detected for property "implicitHeight"


This seems to be caused by https://invent.kde.org/frameworks/kirigami/-/commit/f1ef6202fc62ef006be4fdfcc9485ad455a4c3cc


SOFTWARE/OS VERSIONS
KDE Frameworks Version: master
Qt Version: 5.15

ADDITIONAL INFORMATION
Wayland session
One of my monitors has 2x scaling

Comment 1 Nicolas Fella 2020-06-29 12:12:30 UTC

Created attachment 129760 [details]
comparison

Comment 2 Nicolas Fella 2020-06-29 12:13:24 UTC

Created attachment 129761 [details]
In application

Comment 3 Nate Graham 2020-07-07 15:41:02 UTC

I'll fix this.

Comment 4 Nate Graham 2020-07-07 15:45:55 UTC

Git commit 41e20ee53c690fb6efeab2a40feb917d889ac624 by Nate Graham, on behalf of Arjen Hiemstra.
Committed on 07/07/2020 at 15:45.
Pushed by ngraham into branch 'master'.

Set height of MenuSeparator properly

Since Kirigami's Separator now only specifies implicitHeight, the
separator used in the background will be resized by Control. If we
specify an explicit height, it will correctly centre again.

M  +1    -0    org.kde.desktop/MenuSeparator.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/41e20ee53c690fb6efeab2a40feb917d889ac624

Comment 5 Nate Graham 2020-07-07 15:46:25 UTC

Actually, Arjen fixed this. :)