| Summary: | Trying to access 'trash settings' from krunner opens systemsettings home page instead | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Kishore Gopalakrishnan <kishore96> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander.lohnau, faure, jaxj337, mo78, nate, notmart, plasma-bugs |
| Priority: | VHI | Keywords: | regression |
| Version: | 5.19.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/5bc6d83ae083632fa4eef21a03b1ef59dd9a852e | Version Fixed In: | 5.19.4 |
| Sentry Crash Report: | |||
|
Description
Kishore Gopalakrishnan
2020-06-28 10:26:43 UTC
Can confirm on KDE Neon Unstable. This issue only exists when using systemsettings, it works fine with kcmshell. https://invent.kde.org/plasma/plasma-workspace/-/commit/e67e8d6d92a1b85e85be1f8f656ff5b51bd90ace This is a bigger problem: If the KCM has no X-KDE-System-Settings-Parent-Category it can't be loaded. This is the case with the other dolphin KCMs and a few others. To try this out add: >X-KDE-System-Settings-Parent-Category=desktopbehavior To the KCM (/usr/share/kservices5/kcmtrash.desktop) and then run kbuildsycoca5. Then you should be able to launch it with: >systemsettings5 kcmtrash The code responsible for this is located in systemsettings/core/MenuItem.cpp in MenuItem::descendantForModule And in SidebarMode line 714 where the method is called null is returned if no parent is found. Darn, this is no good. I guess we have two immediate options: 1. Have the openSystemSettings() function check for the presence of a X-KDE-System-Settings-Parent-Category property and open it in KCMShell if it's missing 2. Allow System Settings itself to display KCMs without the X-KDE-System-Settings-Parent-Category property #1 Cannot be released as a hotfix in Plasma since it lives in the KDeclarative framework which is on a different release schedule (though I suppose we could ask distros to patch it into their older versions). But #2 might be a bit confusing since these KCMs don't otherwise appear in System Settings. Regardless, moving to System Settings for now. Thoughts, everyone? Also I feel like the concept of KCMs that don't appear in System Settings itself somewhat awkward and we may want to review that, long term. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/131 *** Bug 423828 has been marked as a duplicate of this bug. *** Git commit 2ebf8ab391466146a7a6ae3d4dad3e0ff0c7276d by Nate Graham, on behalf of Alexander Lohnau. Committed on 08/07/2020 at 14:00. Pushed by ngraham into branch 'master'. Only open KCM in systemsettings if it can be displayed We have to check for the presence of a X-KDE-System-Settings-Parent-Category entry when opening a KCM in systemsettings. M +2 -1 runners/services/servicerunner.cpp https://invent.kde.org/plasma/plasma-workspace/commit/2ebf8ab391466146a7a6ae3d4dad3e0ff0c7276d Git commit 5bc6d83ae083632fa4eef21a03b1ef59dd9a852e by Nate Graham, on behalf of Alexander Lohnau. Committed on 08/07/2020 at 14:04. Pushed by ngraham into branch 'Plasma/5.19'. Only open KCM in systemsettings if it can be displayed We have to check for the presence of a X-KDE-System-Settings-Parent-Category entry when opening a KCM in systemsettings. (cherry picked from commit 2ebf8ab391466146a7a6ae3d4dad3e0ff0c7276d) M +2 -1 runners/services/servicerunner.cpp https://invent.kde.org/plasma/plasma-workspace/commit/5bc6d83ae083632fa4eef21a03b1ef59dd9a852e Git commit aa84d6c2848f1e0ec45085160e4238a9733f6458 by Alexander Lohnau. Committed on 10/07/2020 at 19:32. Pushed by alex into branch 'master'. Open trash KCM from plasmoid in KCMShell M +1 -1 applets/trash/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/commit/aa84d6c2848f1e0ec45085160e4238a9733f6458 *** Bug 423828 has been marked as a duplicate of this bug. *** *** Bug 424323 has been marked as a duplicate of this bug. *** |