Summary: | Plasma crashed in AppsModel::data() when trying to edit items in full screen start menu | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Umit N <umitn> |
Component: | Application Menu (Kicker) | Assignee: | Eike Hein <hein> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | nate, plasma-bugs |
Priority: | NOR | Keywords: | drkonqi |
Version: | 5.19.1 | ||
Target Milestone: | 1.0 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/28560c5d1c2e3a22593c716b399e73cb3e27f32f | Version Fixed In: | 5.26 |
Description
Umit N
2020-06-26 00:31:16 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/692 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2104 Git commit 28560c5d1c2e3a22593c716b399e73cb3e27f32f by David Edmundson. Committed on 15/09/2022 at 15:55. Pushed by davidedmundson into branch 'master'. [applets/kickoff] Always instantiate KService::Ptr member Code uses m_service unconditionally in many branches, it is exposed as public API. Given KService is a data class with an isValid method, it's clearer to ensure that KService::Ptr always returns a valid object which in turn can then be valid rather than having two paths for the same goal. This can be relevant in a situation where an entry using the "preferred" schema references an entry that doesn't exist. M +7 -5 applets/kicker/plugin/appentry.cpp https://invent.kde.org/plasma/plasma-workspace/commit/28560c5d1c2e3a22593c716b399e73cb3e27f32f |