| Summary: |
KFileItem::iconName ignorant of isSlow() and can block gui thread |
| Product: |
[Frameworks and Libraries] frameworks-kio
|
Reporter: |
Harald Sitter <sitter> |
| Component: |
general | Assignee: |
KIO Bugs <kio-bugs-null> |
| Status: |
REPORTED
---
|
|
|
| Severity: |
normal
|
CC: |
accounts+kde, kdelibs-bugs-null, nate, postix
|
| Priority: |
NOR
|
Keywords: |
efficiency-and-performance |
| Version First Reported In: |
git master | |
|
| Target Milestone: |
--- | |
|
| Platform: |
Other | |
|
| OS: |
Linux | |
|
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=178678
|
|
Latest Commit:
|
|
Version Fixed/Implemented In:
|
|
|---|
|
Sentry Crash Report:
|
|
| |
|---|
| Bug Depends on: |
|
|
|
| Bug Blocks: |
423082, 504984
|
|
|
``` if (isLocalUrl && !delaySlowOperations && isDir()) { if (isDirectoryMounted(url)) { d->m_iconName = iconFromDirectoryFile(url.toLocalFile()); ``` if the file system is a mounted sshfs or cifs we'll read the .directory files but really we shouldn't because they are network bound and may be slow. Furthermore they may be backed by HDDs which may crumble under stress. Since iconFromDirectoryFile does blocking POSIX reads this effectively means the gui thread will block on slow network mounts. isSlow() should be taken into consideration somewhere in that block.