Bug 423439

Summary: Animated .gif Rendering output size fix is not in the 4.3.1 prealpha appimage
Product: [Applications] krita Reporter: Ahab Greybeard <ahab.greybeard>
Component: AnimationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: halla
Priority: NOR    
Version: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Debian stable   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/krita/commit/7647f6529acd6cbba6a455c04822ca8d610f3687 Version Fixed In:
Sentry Crash Report:

Description Ahab Greybeard 2020-06-24 11:36:55 UTC 
SUMMARY
4.2.9 and 4.3.0 and 23 Jun 4.3.1 prealpha (git 5e750g3) appimages have non-working Width: and Height: controls in the Rendering output window when using .gif as the output option. The rendered output file is always at the same size as the animated image.
(It works fine for .mp4 output.)

The 23 Jun 5.0.0 prealpha appimage (git 96e3af2) has properly working Width: and Height: controls for animated .gif.

Has a fix not been incorporated into the 4.3.1 pre-alpha?
Comment 1 Halla Rempt 2020-06-24 11:49:11 UTC 
Could be... Would that be this commit: 

commit 3efcd3e648c62b017b3146b9efb6826d6d1aaa0d
Author: Ivan Yossi <ghevan@gmail.com>
Date:   Mon Apr 27 02:07:01 2020 -0500

    Fix ffmpeg argument construct for GIF save
    
    BUG:420215

diff --git a/plugins/extensions/animationrenderer/video_saver.cpp b/plugins/extensions/animationrenderer/video_saver.cpp
index 2394d54e2b..d2aa947a58 100644
--- a/plugins/extensions/animationrenderer/video_saver.cpp
+++ b/plugins/extensions/animationrenderer/video_saver.cpp
@@ -261,14 +261,18 @@ KisImportExportErrorCode VideoSaver::encode(const QString &savedFilesMask, const
                  << "-start_number" << QString::number(clipRange.start())
                  << "-i" << savedFilesMask
                  << "-i" << palettePath
-                 << "-lavfi" << "[0:v][1:v] paletteuse"
-                 << "-y" << resultFile;
+                 << "-lavfi";
+
+            QString filterArgs;
 
             // if we are exporting out at a different image size, we apply scaling filter
             if (m_image->width() != options.width || m_image->height() != options.height) {
-                args << "-vf" << exportDimensions;
+                filterArgs.append(exportDimensions + "[0:v];");
             }
 
+            args << filterArgs.append("[0:v][1:v] paletteuse")
+                 << "-y" << resultFile;
+
 
             dbgFile << "savedFilesMask" << savedFilesMask << "start" << QString::number(clipRange.start()) << "duration" << clipRange.duration();
 
lines 1-34/34 (END)

?
Comment 2 Halla Rempt 2020-06-24 11:53:09 UTC 
Git commit 7647f6529acd6cbba6a455c04822ca8d610f3687 by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 24/06/2020 at 11:52.
Pushed by rempt into branch 'krita/4.3'.

Fix ffmpeg argument construct for GIF save
Related: bug 420215
(cherry picked from commit 3efcd3e648c62b017b3146b9efb6826d6d1aaa0d)

M  +7    -3    plugins/extensions/animationrenderer/video_saver.cpp

https://invent.kde.org/graphics/krita/commit/7647f6529acd6cbba6a455c04822ca8d610f3687