Bug 423378

Summary: Wish : Advanced selection tool functionality
Product: [Applications] krita Reporter: stephen <tgdev001>
Component: Tools/SelectionAssignee: Krita Bugs <krita-bugs-null>
Status: REPORTED ---    
Severity: wishlist CC: griffinvalley, tamtamy.tymona
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: All   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Advanced Selection Tool Demo

Description stephen 2020-06-23 02:00:26 UTC
Created attachment 129599 [details]
Advanced Selection Tool Demo

SUMMARY

This is an idea proposal to have the selection tool to perform "better".
Explanation : advanced functionalities consist in the following elements :

-With the polygonal selection tool, double-clicking automatically manage to close the perimeter of the selection shape drawn on the canvas, by tracing a straight line going from the last click-point coordinates to the first click-point coordinates, kinda like when you lift your pen pressure or release your click when you use the lasso/freehand selection tool;

-With the freehand selection tool in use, holding the ALT modifier key, enables you to maintain your drawn selection shape and then switch to the polygonal tool from the point where you release your click or pen press without committing your selection shape until you double-click on the canvas or lift/release your pen press/click and vice-versa.(I included a 
video to better explain this one).
Comment 1 wolthera 2020-06-23 10:18:58 UTC
The second one already exists, it uses 'ctrl' instead.

As for the first one, we try to avoid double clicking in the tools because doubleclicking is really bad UX for tablet+stylii, so we'd need to figure out a different way to invoke that...
Comment 2 stephen 2020-06-23 12:01:31 UTC
(In reply to wolthera from comment #1)
> The second one already exists, it uses 'ctrl' instead.
> 
> As for the first one, we try to avoid double clicking in the tools because
> doubleclicking is really bad UX for tablet+stylii, so we'd need to figure
> out a different way to invoke that...

Why is it bad tho ? Because double-clicking works only with the polygonal lasso tool and quickly pressing twice on my Huion-tablet gives the double-click action and commits my selection, fine(of course, I was using Photoshop).

Personally, I think it's rather a very good UX for either mouses and tablets+stylii.
Seriously.
Comment 3 stephen 2020-06-23 19:26:35 UTC
(In reply to wolthera from comment #1)
> The second one already exists, it uses 'ctrl' instead.
> 
> As for the first one, we try to avoid double clicking in the tools because
> doubleclicking is really bad UX for tablet+stylii, so we'd need to figure
> out a different way to invoke that...

Also, what you said about the second one doesn't work for me. 
What should I see in the shortcuts settings to locate the function then ?
Comment 4 stephen 2020-08-30 17:37:10 UTC
(In reply to wolthera from comment #1)
> The second one already exists, it uses 'ctrl' instead.
> 
> As for the first one, we try to avoid double clicking in the tools because
> doubleclicking is really bad UX for tablet+stylii, so we'd need to figure
> out a different way to invoke that...

Greetings again. 
Using a stable build of Krita Plus(4.4.0 alpha, git 6f363db), I noticed that the advanced selection technique can be used if we select the Freehand Outline Selection tool. However, however, there's an issue I'll describe as follows:

In the case of adding multiple individual selection areas, once you switch to the Polyline tool as you draw the selection area and while holding CTRL, the selection mode shifts to Subtract, and switching back to the freehand selection tool as you release the CTRL key doesn't work. Neither does it even if you try pressing SHIFT afterwards while still holding the left click input before completing the selection area. 

As a result, the USE CASE of adding multiple selections fails for the second selection area everytime you try to switch to Polyline Tool while tracing the outline of the selection.

Let me know if I should write a new bug report for this.

OS used : Windows 10 1909
Comment 5 Tiar 2020-09-12 01:27:55 UTC
Yes, please do create a new bug report for that issue.

Also this is in regards to the functionality mentioned in the second point (alt-key to make straight lines). I take it that the first one (auto-closing selection) is still valid? If no, please close this bug report. If yes, then just a new UX (not, or at least not only double-click) needs to be figured out.