Bug 423335

Summary: Assert crash at closing focused tab with new annotation toolbar
Product: [Applications] okular Reporter: Laura David Hurka <laura.stern>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: crash CC: aacid, sepamou, simgunz
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Backtrace: Assertion fails at closing a tab

Description Laura David Hurka 2020-06-21 22:01:49 UTC
Created attachment 129573 [details]
Backtrace: Assertion fails at closing a tab

SUMMARY
I have ninja install-ed the new annotation toolbar from git master. When I close a tab by middle-click, an assertion fails, see backtrace

STEPS TO REPRODUCE
1. Open two tabs
2. Close one tab by middle-click in the tab bar

OBSERVED RESULT
Assertion fails somewhere in setupAnnotationToolBarVisibilityAction().

EXPECTED RESULT
No assertion fails. :)

SOFTWARE/OS VERSIONS
KDE Neon 5.19
KDE Plasma Version: 5.19.1
KDE Frameworks Version: 5.71
Qt Version: 5.14.2

ADDITIONAL INFORMATION
The annotation toolbar works otherwise. I didn’t open the annotation toolbar, but I did customize the main toolbars before.
Comment 1 Simone Gaiarin 2020-06-22 06:27:09 UTC
For me it crashes with:

ASSERT: "itMainWindow != widgets.end()" in file ../ui/annotationactionhandler.cpp, line 783

only when closing the focused tab. Does not crash when closing the other tabs. Can you confirm?

I'll investigate.
Comment 2 Laura David Hurka 2020-06-22 06:38:02 UTC
Yes, didn’t notice that.
Comment 3 Simone Gaiarin 2020-06-22 07:00:44 UTC
See https://invent.kde.org/graphics/okular/-/merge_requests/200
Comment 4 Albert Astals Cid 2020-07-14 21:41:56 UTC
Simone missed a : in the commit log 

https://invent.kde.org/graphics/okular/-/commit/1a581c4135fa8806c6d6288f5a55776ae2aecd15
Comment 5 Albert Astals Cid 2020-07-16 17:16:40 UTC
*** Bug 424249 has been marked as a duplicate of this bug. ***