Summary: | Adding a "pure" tag group to another tag group doesn't work as expected | ||
---|---|---|---|
Product: | [Applications] kphotoalbum | Reporter: | Johannes Zarl-Zierl <johannes> |
Component: | XML backend | Assignee: | KPhotoAlbum Bugs <kphotoalbum-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version First Reported In: | GIT master | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/kphotoalbum/commit/ab47cb0bf3227458846e019c1cc6b00c131ade19 | Version Fixed In: | |
Sentry Crash Report: |
Description
Johannes Zarl-Zierl
2020-06-21 21:48:12 UTC
Git commit 366c46fa04872ccc7becc838fa61e887490d8ecd by Johannes Zarl-Zierl. Committed on 21/06/2020 at 21:57. Pushed by johanneszarl into branch 'master'. Issue diagnostic when invalid id reference is used in member-group. Note: I also checked that this is the only remaining place in FileReader where an inconsistency is just ignored by continuing to the next value. So things as decribed in bug 423334 *should* no longer go unnoticed for such a long time. M +4 -1 XMLDB/FileReader.cpp https://invent.kde.org/graphics/kphotoalbum/commit/366c46fa04872ccc7becc838fa61e887490d8ecd Git commit ab47cb0bf3227458846e019c1cc6b00c131ade19 by Johannes Zarl-Zierl. Committed on 22/06/2020 at 00:00. Pushed by johanneszarl into branch 'master'. Consider MemberMap data when saving categories. If a tag group is only known in the MemberMap (because it was not used as a tag on an image or video), then special care is needed when saving to prevent inconsistent data from being written. See the attached bug number for an analysis of a possible bug scenario. M +1 -0 AnnotationDialog/ListSelect.cpp M +4 -12 XMLDB/FileWriter.cpp https://invent.kde.org/graphics/kphotoalbum/commit/ab47cb0bf3227458846e019c1cc6b00c131ade19 |