Bug 423211

Summary: Legal Notice in khelpcenter shows unreadable text when Breeze Dark global theme and Breeze Dark plasma style are used
Product: [Frameworks and Libraries] frameworks-kdoctools Reporter: Valentina <valentina>
Component: generalAssignee: Documentation Editorial Team <kde-doc-english>
Status: RESOLVED FIXED    
Severity: normal CC: kdelibs-bugs, nate, plasma-bugs, yurchor
Priority: NOR    
Version: 5.71.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/frameworks/kdoctools/commit/8b6ec34db29dd8c3c387c6697a49a98329a7b217 Version Fixed In: 5.72
Sentry Crash Report:
Attachments: khelpcenter->Application Manuals->Utilities->Ark

Description Valentina 2020-06-19 09:57:10 UTC 
SUMMARY
When using Breeze Dark global theme and Breeze Dark plasma style, text in Legal Notice on khelpcenter is unreadable.

STEPS TO REPRODUCE
1. Set global theme to Breeze Dark(automatically plasma style will become Breeze Dark)
2. Open khelpcenter->any section(e. g. Application Manuals->Utilities->Ark)
3. Select Legal Notice

OBSERVED RESULT
Black text on dark background.

EXPECTED RESULT
Text should always be readable.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.71.0
Qt Version: 5.14.2
Comment 1 Valentina 2020-06-19 09:58:53 UTC 
Created attachment 129519 [details]
khelpcenter->Application Manuals->Utilities->Ark
Comment 2 Nate Graham 2020-06-19 13:35:41 UTC 
Probably a hardcoded color in KHelpCenter.
Comment 3 Yuri Chornoivan 2020-06-19 14:39:34 UTC 
(In reply to Nate Graham from comment #2)
> Probably a hardcoded color in KHelpCenter.

Not exactly in KHelpCenter:

https://invent.kde.org/frameworks/kdoctools/-/blob/master/common/en/kde-default.css#L315

But what should we do? Do not hardcode it?
Comment 4 Nate Graham 2020-06-19 16:26:19 UTC 
Yes, these colors should not be hardcoded. They should be getting the color from the active color scheme, specifically the TextColor property.
Comment 5 Yuri Chornoivan 2020-06-19 17:05:22 UTC 
Git commit 8b6ec34db29dd8c3c387c6697a49a98329a7b217 by Yuri Chornoivan.
Committed on 19/06/2020 at 17:05.
Pushed by yurchor into branch 'master'.

Use consistent style for FDL notice

M  +1    -0    common/en/fdl-notice.html

https://invent.kde.org/frameworks/kdoctools/commit/8b6ec34db29dd8c3c387c6697a49a98329a7b217
Comment 6 Nate Graham 2020-06-19 19:41:52 UTC 
Thanks Yuri!