Bug 423121

Summary:	Adding complete task event in journal doesn't work if task completed via "completed" slider
Product:	[Applications] korganizer	Reporter:	der_fenix <derfenix>
Component:	todoview	Assignee:	kdepim bugs <pim-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gjditchfield
Priority:	NOR
Version First Reported In:	5.14.2
Target Milestone:	---
Platform:	Arch Linux
OS:	All
Latest Commit:	https://invent.kde.org/pim/incidenceeditor/commit/6b5c5a64c2a41117df126e26e2859cb59155f2c5	Version Fixed/Implemented In:
Sentry Crash Report:

Description der_fenix 2020-06-17 20:58:07 UTC

SUMMARY
If I complete task by checking the checkbox on it - task completion will be stored in journal. But if I move the slider to the 100%, checkbox will be checked automatically, task will be considered as completed, but no journal entry will be created.


STEPS TO REPRODUCE
1. Create task
2. Open it and move "Completed" slider to 100% and save
3. Task will be marked as completed (checkbox checked)
4. Open the Journal

OBSERVED RESULT

No record about completed task in journal

EXPECTED RESULT

Record about task completion should be added in journal as it does after checking task's checkbox manually

Comment 1 der_fenix 2020-06-19 15:16:15 UTC

Also, journal entry is not created if the task was marked as completed from other app (calendar synced via caldav)

Comment 2 gjditchfield 2020-07-05 19:19:57 UTC

The situation described in comment 1 is quite different from the main description, and I'm not sure KOrganizer should generate a journal entry then. (Who marked the to-do as complete?)  I suggest that you enter a new "wish list" bug for the CalDAV case, if you want that behavior, so we can close this bug report when the "slider" problem is fixed.

Comment 3 Bug Janitor Service 2020-07-05 19:43:19 UTC

A possibly relevant merge request was started @ https://invent.kde.org/pim/incidenceeditor/-/merge_requests/1

Comment 4 Bug Janitor Service 2020-07-06 18:26:36 UTC

A possibly relevant merge request was started @ https://invent.kde.org/pim/incidenceeditor/-/merge_requests/2

Comment 5 gjditchfield 2020-07-06 18:26:51 UTC

Git commit 6b5c5a64c2a41117df126e26e2859cb59155f2c5 by Glen Ditchfield.
Committed on 06/07/2020 at 18:24.
Pushed by gditchfield into branch 'release/20.04'.

Generate a journal entry when the completion percentage is set to 100%

If the "record completed to-dos in journal entries" preference is set,
this patch will record the competion if the to-do is completed by setting
the completion percentage to 100% in an incidence editor.

M  +5    -1    src/incidencecompletionpriority.cpp

https://invent.kde.org/pim/incidenceeditor/commit/6b5c5a64c2a41117df126e26e2859cb59155f2c5