Summary: | Konqueror KHTML text input not shown, button not disarmed until window focus change | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-khtml | Reporter: | Taketo Kabe <dkabe> |
Component: | general | Assignee: | Martin Sandsmark <martin.sandsmark> |
Status: | RESOLVED MOVED | ||
Severity: | normal | CC: | kdelibs-bugs |
Priority: | NOR | ||
Version: | 5.66.0 | ||
Target Milestone: | --- | ||
Platform: | RedHat Enterprise Linux | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=429126 | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
half-heated attempt to make typed text appear immediately
Quarter-hearted implementation to make text appear on type, button unarms Patch to render QLineEdit text caret cursor visible in decoreated KLineEdit Patch to render QLineEdit text caret cursor visible in decorated KLineEdit |
Description
Taketo Kabe
2020-06-14 07:15:04 UTC
Created attachment 129743 [details]
half-heated attempt to make typed text appear immediately
This patch will make the text appear immediately on type.
The textbox caret cursor is still missing. I don't know why the caret doesn't appear.
The patched line is a quarter-heated job of what had been done in
#if QT_VERSION < QT_VERSION_CHECK(5, 0, 0)
region below.
Created attachment 130237 [details]
Quarter-hearted implementation to make text appear on type, button unarms
A revised patch of above for KHTML.
Text input in textfield appear immediately, and button unarms on onClick.
The text caret cursor seems invisible, but you can barly see it when
typing a text and pressing left arrow button; the text caret cursor is
rendered in background color, so it is nearly invisible.
Fixing this needs a patch for QLineEdit, which follows.
Created attachment 130238 [details]
Patch to render QLineEdit text caret cursor visible in decoreated KLineEdit
The text caret cursor in QLineEdit is temporary rendered by
QPainter->setCompositionMode in QPainter::RasterOp_NotDestination,
but this seems to not work nicely in decorated (CSS "border-style" set)
KLineEdit widget. It makes text caret cursor rendered in background color.
This patch makes it uses QPainter::RasterOp_SourceOrNotDestination,
which makes text caret cursor rendered visible.
WARNING: this patch is for Qt5 qtbase; not for khtml. I'll try reporting this to Qt.
Created attachment 130335 [details]
Patch to render QLineEdit text caret cursor visible in decorated KLineEdit
Warning: this patch is for qt5-qtbase, not for khtml.
After experimenting for various color schemes, QLineEdit (QTextEdit) needed major overhaul
of drawDursor().
The attached patch will finally render the text caret cursor in fair colors, testcase HTML below.
<HTML>
<BODY style="background:#DDDDDD" >
<FORM action="./">
<INPUT id=1 type="TEXT" size=20 /> undecorated<br />
<INPUT id=2 type="TEXT" size=20 style="border-style:solid; border-color:#FF0000; background: inherit; color:#000000" /> bg:inherit, color:black<br />
<INPUT id=3 type="TEXT" size=20 style="border-style:solid; border-width:1;" /> border only<br />
<INPUT id=4 type="TEXT" size=20 style="border-style:solid; border-color:#FF0000; background: #777777; color:#000000" /> bg:777, color:000<br />
<INPUT id=5 type="TEXT" size=20 style="border-style:solid; border-color:#0000FF; background: #111111; color:#EEEEEE;" /> bg:111, color:eee<br />
<INPUT id=6 type="TEXT" size=20 style="border-style:solid; border-color:#00FFFF; background: #dddddd; color:#00EEEE;" /> bg:ddd, color:0ee<br />
<INPUT id=7 type="TEXT" size=20 style="border-style:solid; border-color:#FFFF00; background: #222222; color:#EEEE00;" /> bg:222, color:ee0<br />
<INPUT id=8 type="TEXT" size=20 style="border-style:solid; border-color:#777777; background: inherit; color:#880088;" /> bg:inh, color:808<br />
</FORM>
</BODY>
</HTML>
(I still cannot be able to report this in KHTML, since the site seems to disable cursor blink timer)
Superseeded by bug 429126. |