Summary: | GHNS window indicates that an addon was installed despite installation failure | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Patrick Silva <bugseforuns> |
Component: | general | Assignee: | Alexander Lohnau <alexander.lohnau> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | admin, alexander.lohnau, kdelibs-bugs, nate |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/knewstuff/commit/520f4ca48fd30b866fb3cc52705e49029428f1be | Version Fixed In: | 5.73 |
Sentry Crash Report: | |||
Attachments: | screen recording |
Can reproduce, I have fixed a similar bug for installations that use install scripts some time ago (for example the dolphin services). Maybe I will find the time to loo into this one :-). A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/10 Git commit 520f4ca48fd30b866fb3cc52705e49029428f1be by Alexander Lohnau. Committed on 17/07/2020 at 08:07. Pushed by alex into branch 'master'. Set entry to uninstalled if installation fails In the described case the entries state is set to installed when the lambda is called. Consequently the state was not reset and the entry was marked as installed. FIXED-IN: 5.73 M +1 -1 src/core/installation.cpp https://invent.kde.org/frameworks/knewstuff/commit/520f4ca48fd30b866fb3cc52705e49029428f1be |
Created attachment 129253 [details] screen recording SUMMARY Button labeled "Uninstall" and the green icon in the upper left corner indicate that an addon was installed even if the installation failed. Watch the attached screen recording please. EXPECTED RESULT not installed addon should never be listed as installed. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.71.0 Qt Version: 5.14.2