| Summary: | No action (assignable shortcut) for Magnetic Selection Tool | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Yu-Hsuan Lai <raincolee> |
| Component: | Tools/Selection | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | ||
| Version: | 4.3.0-beta2 | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/8b1d39d96f2c3a38a6ca49f1d44d5666d145ff80 | Version Fixed In: | |
|
Description
Yu-Hsuan Lai
2020-06-10 09:32:43 UTC
Looks like most of the .action files in the plugins/tools folder are broken, which is why the actions are also present in krita/krita.action, which shouldn't be necessary... (In reply to Boudewijn Rempt from comment #1) > Looks like most of the .action files in the plugins/tools folder are broken, > which is why the actions are also present in krita/krita.action, which > shouldn't be necessary... Is it possible to workaround this without building my own Krita? Like manually creating this .actions file with Magnetic Selection Tool or something? Yes, that's possible, but I'm working on a fix right now, which will be in tonights stable nightly build. Git commit 5b41b826fb1d4fe8faf9a8d15b4def762dd468bc by Boudewijn Rempt. Committed on 10/06/2020 at 10:25. Pushed by rempt into branch 'master'. Fix the plugins/tool action files These files only had text, the action was defined in krita/krita.action. There are still tools in plugins that have their actions defined in krita/krita.action, but splitting them out in action files in the plugins can wait. M +0 -121 krita/krita.action M +9 -5 libs/widgetutils/kis_action_registry.cpp M +12 -2 plugins/tools/basictools/KisToolPath.action M +12 -2 plugins/tools/basictools/KisToolPencil.action M +12 -2 plugins/tools/selectiontools/KisToolSelectContiguous.action M +12 -2 plugins/tools/selectiontools/KisToolSelectElliptical.action M +12 -2 plugins/tools/selectiontools/KisToolSelectMagnetic.action M +12 -2 plugins/tools/selectiontools/KisToolSelectOutline.action M +12 -2 plugins/tools/selectiontools/KisToolSelectPath.action M +10 -2 plugins/tools/selectiontools/KisToolSelectPolygonal.action M +12 -2 plugins/tools/selectiontools/KisToolSelectRectangular.action M +12 -2 plugins/tools/selectiontools/KisToolSelectSimilar.action M +3 -2 plugins/tools/svgtexttool/SvgTextTool.action M +12 -2 plugins/tools/tool_crop/KisToolCrop.action M +12 -2 plugins/tools/tool_polygon/KisToolPolygon.action M +12 -2 plugins/tools/tool_polyline/KisToolPolyline.action M +12 -2 plugins/tools/tool_transform2/KisToolTransform.action https://invent.kde.org/graphics/krita/commit/5b41b826fb1d4fe8faf9a8d15b4def762dd468bc Git commit ce3a1a3194dc4347d582ff20781f4cae16a6f2cd by Boudewijn Rempt. Committed on 10/06/2020 at 10:30. Pushed by rempt into branch 'master'. Add a warning if an action file is empty This mostly seems to happen when people forget thet text element, though, the parser isn't the most robust in the world. M +5 -5 libs/widgetutils/kis_action_registry.cpp https://invent.kde.org/graphics/krita/commit/ce3a1a3194dc4347d582ff20781f4cae16a6f2cd Git commit 741ba2ad61109764e5ddd8f8c1bf9b1d11b7207e by Boudewijn Rempt. Committed on 10/06/2020 at 10:31. Pushed by rempt into branch 'krita/4.3'. Add a warning if an action file is empty This mostly seems to happen when people forget thet text element, though, the parser isn't the most robust in the world. (cherry picked from commit ce3a1a3194dc4347d582ff20781f4cae16a6f2cd) M +5 -5 libs/widgetutils/kis_action_registry.cpp https://invent.kde.org/graphics/krita/commit/741ba2ad61109764e5ddd8f8c1bf9b1d11b7207e Git commit 8b1d39d96f2c3a38a6ca49f1d44d5666d145ff80 by Boudewijn Rempt. Committed on 10/06/2020 at 10:30. Pushed by rempt into branch 'krita/4.3'. Fix the plugins/tool action files These files only had text, the action was defined in krita/krita.action. There are still tools in plugins that have their actions defined in krita/krita.action, but splitting them out in action files in the plugins can wait. (cherry picked from commit 5b41b826fb1d4fe8faf9a8d15b4def762dd468bc) M +0 -121 krita/krita.action M +9 -3 libs/widgetutils/kis_action_registry.cpp M +12 -2 plugins/tools/basictools/KisToolPath.action M +12 -2 plugins/tools/basictools/KisToolPencil.action M +12 -2 plugins/tools/selectiontools/KisToolSelectContiguous.action M +12 -2 plugins/tools/selectiontools/KisToolSelectElliptical.action M +12 -2 plugins/tools/selectiontools/KisToolSelectMagnetic.action M +12 -2 plugins/tools/selectiontools/KisToolSelectOutline.action M +12 -2 plugins/tools/selectiontools/KisToolSelectPath.action M +10 -2 plugins/tools/selectiontools/KisToolSelectPolygonal.action M +12 -2 plugins/tools/selectiontools/KisToolSelectRectangular.action M +12 -2 plugins/tools/selectiontools/KisToolSelectSimilar.action M +3 -2 plugins/tools/svgtexttool/SvgTextTool.action M +12 -2 plugins/tools/tool_crop/KisToolCrop.action M +12 -2 plugins/tools/tool_polygon/KisToolPolygon.action M +12 -2 plugins/tools/tool_polyline/KisToolPolyline.action M +12 -2 plugins/tools/tool_transform2/KisToolTransform.action https://invent.kde.org/graphics/krita/commit/8b1d39d96f2c3a38a6ca49f1d44d5666d145ff80 Was this fix supposed to be included in the 4.3.0 release? I just downloaded 4.3.0 (not 4.3.0-beta2) but Magnetic Selection Tool still has no assignable shortcut. It's only in the 4.3 branch; I fixed it after the 4.3.0 went into hard freeze. |