Bug 422630

Summary: Discover Updates View: swap "Update" and "Check for Updates" buttons?
Product: [Applications] Discover Reporter: Gregor Mi <codestruct>
Component: discoverAssignee: Dan Leinir Turthra Jensen <leinir>
Severity: wishlist CC: aleixpol, claudius.ellsel, nate, sephiroth_pk
Priority: NOR Keywords: usability
Version: 5.18.5   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.21

Description Gregor Mi 2020-06-08 13:38:59 UTC
Currently, in the Updates View there are one or two buttons on the top right:

- [ Check for Updates ]                   if there no updates available
- [ Update ] and [ Check for Updates ]    if there are updates available

I am not sure about the KDE HIG, but should the primary action not be on the right side?
With this as resulting layout:

- [ Check for Updates ] and [ Update ]
Comment 1 Nate Graham 2020-08-26 03:07:14 UTC
There isn't really a hard-and-fast rule for this. It's easy enough to change, but is it worth it?
Comment 2 Riccardo Robecchi 2020-12-11 11:37:11 UTC
(In reply to Nate Graham from comment #1)
> There isn't really a hard-and-fast rule for this. It's easy enough to
> change, but is it worth it?

I find myself often clicking on "check for updates" instead of "update" as I expect the relevant action to be the rightmost one, so I would be in favour of this.
Comment 3 Bug Janitor Service 2020-12-11 14:48:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/58
Comment 4 Aleix Pol 2020-12-16 17:52:40 UTC
Git commit bd4c1ac7904a2ec6d288bfe9e0e0c32c6e059863 by Aleix Pol Gonzalez, on behalf of Nate Graham.
Committed on 16/12/2020 at 17:13.
Pushed by ngraham into branch 'master'.

Reverse position of Refresh and Update actions in desktop view

People seem to feel that the Update action should be the right-most one
in desktop view. This commit accomplishes that, without changing the
ordering in mobile/narrow view, which would inappropriately cause the
Refresh action to be the center one in the floating action button.
FIXED-IN: 5.21

M  +5    -2    discover/qml/UpdatesPage.qml