| Summary: | Crash when tagging images in kphotoalbum | ||
|---|---|---|---|
| Product: | [Applications] kphotoalbum | Reporter: | Joan <aseques> |
| Component: | general | Assignee: | KPhotoAlbum Bugs <kphotoalbum-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | johannes |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | 5.6.1 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/kphotoalbum/commit/c6fb6c1214e6a5b65d34573096e6ddb5dcd2deb8 | Version Fixed In: | 5.7.0 |
| Sentry Crash Report: | |||
| Attachments: |
attachment-26490-0.html
Script for logging calls to ffmpeg ffmpeg logs |
||
|
Description
Joan
2020-06-06 21:33:52 UTC
Hello Joan, Thanks for the bug report! The backtrace seems to indicate a problem with video thumbnail generation. Does the crash also happen if you simply wait (without tagging any images)? Johannes Created attachment 129117 [details] attachment-26490-0.html It can be at any moment, sometimes I see I when scrolling photos for example, but since it was consistent this time when tagging I thought it was the cause. Might be related to background tasks as you say. If you need any more information I'd be glad to help. Joan El dg., 7 juny 2020, 0.41, Johannes Zarl-Zierl <bugzilla_noreply@kde.org> va escriure: > https://bugs.kde.org/show_bug.cgi?id=422555 > > Johannes Zarl-Zierl <johannes@zarl-zierl.at> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| |johannes@zarl-zierl.at > > --- Comment #1 from Johannes Zarl-Zierl <johannes@zarl-zierl.at> --- > Hello Joan, > > Thanks for the bug report! > > The backtrace seems to indicate a problem with video thumbnail generation. > Does the crash also happen if you simply wait (without tagging any images)? > > Johannes > > -- > You are receiving this mail because: > You reported the bug. Created attachment 129129 [details]
Script for logging calls to ffmpeg
Can you try adding the attached script to your path and see if ffmpeg is having problems with some files?
A quick way to add the script to your path would be:
mkdir ~/temp-ffmpeg
# copy script to ~/temp-ffmpeg
chmod +x ~/temp-ffmpeg/ffmpeg
export PATH="~/temp-ffmpeg:$PATH"
kphotoalbum
Afterwards, you should find a file /tmp/ffmpeg.log on your system.
Of special interest would be any lines not starting with "[0]" and/or the last few lines.
Created attachment 129147 [details]
ffmpeg logs
Relevant part of the logs generated with Johannes's script.
I just tried with one of the files (see attached the logs of your script), and the errors are the following: cvlc /media/jjuvan/TOSHIBA_FOTOS/Fotos/2019/agost/YDXJ0002.MP4 VLC media player 3.0.8 Vetinari (revision 3.0.8-0-gf350b6b5a7) [000055a73b72d800] dummy interface: using the dummy interface module... Failed to open VDPAU backend libvdpau_i965.so: cannot open shared object file: No such file or directory [00007fc2b0d823b0] main decoder error: Timestamp conversion failed for 21354667: no reference clock [00007fc2b0d823b0] main decoder error: Could not convert timestamp 0 for faad [00007fc2b0cc1ae0] main decoder error: Timestamp conversion failed for 21390701: no reference clock [00007fc2b0cc1ae0] main decoder error: Could not convert timestamp 0 for FFmpeg [00007fc2b0cc1ae0] main decoder error: buffer deadlock prevented [00007fc2b0d823b0] main decoder error: buffer deadlock prevented Git commit 7e0c7cb15b78c3920eadfed5f1398c2754cb91dc by Johannes Zarl-Zierl. Committed on 08/06/2020 at 23:27. Pushed by johanneszarl into branch 'master'. ExtractOneVideoFrame: fix connect statements. Fix incorrect signal/slot connection that may prevent proper error handling when extracting video frames fails. M +10 -2 ImageManager/ExtractOneVideoFrame.cpp M +8 -2 ImageManager/ExtractOneVideoFrame.h https://invent.kde.org/graphics/kphotoalbum/commit/7e0c7cb15b78c3920eadfed5f1398c2754cb91dc Thanks for the log file and for the additional info! I think I may have found the culprit. A change in the Qt library that we didn't notice may have prevented proper error handling when ffmpeg fails to extract video thumbnails. I think I can sync Neon user edition to git master this week so that you can try the fix without compiling kphotoalbum yourself... Great, I'll check it out when the version is updated. Thanks *** Bug 412409 has been marked as a duplicate of this bug. *** I've just synced the KDE Neon branch with master. You should get the updated package soon. Please report back if this fixes the crash for you... Btw. thanks for taking the time to close your related bug report - this really makes a difference for us! Cheers, Johannes Hi Joan, Did you have time to check whether the fix works for you? Cheers, Johannes I just realized that the 5.x branch is only used for the Neon/stable *developer* edition. I.e. you won't get the updated package in Neon user edition unless we do a proper release. We are not far from a release, but I think it will take around a month to finalize everything. Sorry for the additional delay... Git commit c6fb6c1214e6a5b65d34573096e6ddb5dcd2deb8 by Johannes Zarl-Zierl. Committed on 24/06/2020 at 22:29. Pushed by johanneszarl into branch 'master'. Changelog M +2 -0 ChangeLog https://invent.kde.org/graphics/kphotoalbum/commit/c6fb6c1214e6a5b65d34573096e6ddb5dcd2deb8 I've marked the bug as fixed for now. If you experience any problems with 5.7.0 (once it has been released) or an up-to-date version from git then please reopen this bug (or open a new one)! Cheers, Johannes Hi Johannes, I was waiting for the fix until you say that it wasn't comming yet. I tried compiling and ti works perfectly (I see warnings about thumbnails not being generated, but kphotoalbum is not crashing). On thing only, on the backup part tells us to use kpa-backup.sh, but it doesn't work: $ ~/.local/bin/kpa-backup.sh --backup qtpaths: could not find a Qt installation of '' QStandardPaths command line client (qtpaths) not usable! Hi Joan! Thanks for the feedback! The issue with kpa-backup.sh seems to be a problem with your Qt installation: kpa-backup calls "qtpaths --types" to verify that qtpaths is working correctly. For some reason, this doesn't work on your system. |