Bug 422486

Summary:	Session manager window edit buttons should be disabled without a selected session
Product:	[Applications] krita	Reporter:	Maximilian Schier <maximilian.schier>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	halla, tamtamy.tymona
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	unspecified
OS:	All
Latest Commit:	3f3d802f63249196a98cb3842999e281ae0925eb	Version Fixed/Implemented In:
Sentry Crash Report:

Description Maximilian Schier 2020-06-05 13:09:26 UTC

SUMMARY
The session manager window currently allows interaction with all buttons (rename, delete, switch to) despite not having a selected session in the list view. This is confusing because it allows pointless interaction and especially for renaming fails way to late, because the user is prompted for a new name with nothing happening on confirmation.

STEPS TO REPRODUCE
1. Select File > Sessions... with no sessions created
2. Click Rename...

OBSERVED RESULT
The user is prompted for a new name, despite no session existing.

EXPECTED RESULT
Ideally it should not be possible to click the modifier buttons without a selected session.

SOFTWARE/OS VERSIONS
Windows: -
macOS: -
Linux/KDE Plasma: Fedora 30 Workstation
(available in About System)
KDE Plasma Version: -
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.5

ADDITIONAL INFORMATION
I have already worked on a patch which disables the buttons depending on selection changed. I will submit this if this is approved.

Comment 1 Halla Rempt 2020-06-05 13:11:36 UTC

If you would submit a patch to invent.kde.org/graphics/krita that would be awesome.

Comment 2 Maximilian Schier 2020-06-11 07:37:11 UTC

Git commit 3f3d802f63249196a98cb3842999e281ae0925eb by Maximilian Schier.
Committed on 11/06/2020 at 07:02.
Pushed by dkazakov into branch 'master'.

Toggle session manager button availability depending on session selection

In the session manager window rename, switch to and delete buttons
were always enabled, despite having no actions without a selected
session.

These buttons are now enabled depending on selection of a session.

Co-Developed-By: Maximilian Schier <maximilian.schier@stud.uni-hannover.de>
Co-Developed-By: Niclas Wüstenbecker <niclas.wuestenbecker@stud.uni-hannover.de>

M  +20   -1    libs/ui/dialogs/KisSessionManagerDialog.cpp
M  +2    -0    libs/ui/dialogs/KisSessionManagerDialog.h

https://invent.kde.org/graphics/krita/commit/3f3d802f63249196a98cb3842999e281ae0925eb

Comment 3 Tiar 2020-07-31 17:42:01 UTC

I guess the fact that the MR was merged means it's fixed now.

Comment 4 Tiar 2020-07-31 17:43:42 UTC

@ Maximilian if you want to resolve a bug inside a commit, you can write 
> BUG:422486
instead of
> CCBUG:422486

(CCBUG only adds a comment, doesn't close the issue).

Unless this is not fixed yet - then please reopen and say what is still wrong.