Bug 422472

Summary:	Light theme text is missing on non-US English
Product:	[Applications] kdeconnect	Reporter:	Daniel Tang <danielzgtg.opensource>
Component:	android-application	Assignee:	Albert Vaca Cintora <albertvaka>
Status:	REOPENED ---
Severity:	normal	CC:	anjanik012
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Android
OS:	Android 10.x
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Daniel Tang 2020-06-05 05:04:12 UTC

SUMMARY

The text in KDE Connect global settings's choose light theme is corrupt for all languages except "English (United States)".

This bug is especially severe because one would expect missing translations to just fall back to U.S. English. Instead, the l10n daemon inserted garbage.

STEPS TO REPRODUCE
1. Make sure the Android system language is set to "English (Canada)"
2. Open the drawer
3. Tap "Settings"
4. Tap "Choose theme"
5. Look at the middle option
6. Select it
7. Look at the preference list item description text

The bug similarly affects many other languages expect "English (United States)".

OBSERVED RESULT

"Not set" appears in the preference list item description. The middle item in the radio button list in the dialog does not have any text.

This is confusing because "Not set" suggests "Set by Battery Saver" instead.

EXPECTED RESULT

"Light" appears for both.

SOFTWARE/OS VERSIONS

KDE Connect: bd1d7ca6 (first bad commit), d5946faf (latest commit)
Last good commit is 74532f0c

Device: Android Studio
Skin: Pixel XL
Image: Android 10.0 (Q) Google APIs Intel x86 Atom System Image, API 29, Revision 10

This also affects real physical devices.

Comment 1 Anjani Kumar 2020-07-12 10:09:40 UTC

(In reply to Daniel Tang from comment #0)
> SUMMARY
> 
> The text in KDE Connect global settings's choose light theme is corrupt for
> all languages except "English (United States)".
> 
> This bug is especially severe because one would expect missing translations
> to just fall back to U.S. English. Instead, the l10n daemon inserted garbage.
> 
> STEPS TO REPRODUCE
> 1. Make sure the Android system language is set to "English (Canada)"
> 2. Open the drawer
> 3. Tap "Settings"
> 4. Tap "Choose theme"
> 5. Look at the middle option
> 6. Select it
> 7. Look at the preference list item description text
> 
> The bug similarly affects many other languages expect "English (United
> States)".
> 
> OBSERVED RESULT
> 
> "Not set" appears in the preference list item description. The middle item
> in the radio button list in the dialog does not have any text.
> 
> This is confusing because "Not set" suggests "Set by Battery Saver" instead.
> 
> EXPECTED RESULT
> 
> "Light" appears for both.
> 
> SOFTWARE/OS VERSIONS
> 
> KDE Connect: bd1d7ca6 (first bad commit), d5946faf (latest commit)
> Last good commit is 74532f0c
> 
> Device: Android Studio
> Skin: Pixel XL
> Image: Android 10.0 (Q) Google APIs Intel x86 Atom System Image, API 29,
> Revision 10
> 
> This also affects real physical devices.

Fixed in https://invent.kde.org/network/kdeconnect-android/-/merge_requests/182

Incomplete translations are the cause of it. It can still reappear if the new string resource used in this patch is translated incompletely.

Comment 2 Daniel Tang 2021-02-05 01:23:04 UTC

This bug is happening again