Bug 422471

Summary: Every Workspace or Window Layout preset takes a whole page in the chooser lists
Product: [Applications] krita Reporter: Tyson Tan <tysontanx>
Component: UsabilityAssignee: vanyossi <ghevan>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR Keywords: regression
Version First Reported In: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: All   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Every Workspace or Window Layout preset takes one whole page in the switcher list

Description Tyson Tan 2020-06-05 04:17:21 UTC
Created attachment 129059 [details]
Every Workspace or Window Layout preset takes one whole page in the switcher list

Toolbar --> Choose Workspace button (Rightmost button)
Every Workspace or Window Layout preset takes a whole page in the lists.

Tested:
krita-nightly-x64-v4.3.0-beta2-75-gc6aeea52bd-setup
Windows 10 2004
Comment 1 Halla Rempt 2020-06-05 08:47:36 UTC
This is a regression since 4.2.
Comment 2 vanyossi 2020-06-13 07:09:57 UTC
Git commit 17e41a03957f04735488ac711dd100b5ef32ff36 by Ivan Yossi.
Committed on 13/06/2020 at 07:08.
Pushed by ivany into branch 'krita/4.3'.

Fix Workspaces and gradients lists use full lenght

This separates the aspect ratio from the column count to
allow square sized presets without breaking all other
resources lists.

M  +1    -0    libs/ui/widgets/kis_gradient_chooser.cc
M  +1    -0    libs/ui/widgets/kis_workspace_chooser.cpp
M  +6    -1    libs/widgets/KoTableView.cpp
M  +3    -0    libs/widgets/KoTableView.h

https://invent.kde.org/graphics/krita/commit/17e41a03957f04735488ac711dd100b5ef32ff36
Comment 3 Tyson Tan 2020-06-13 07:34:01 UTC
Thank you @vanyossi ! :D
Comment 4 Halla Rempt 2020-06-15 10:27:29 UTC
Git commit 216eeaeb6601d41725920b842cfb7b4c092d2928 by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 15/06/2020 at 10:27.
Pushed by rempt into branch 'krita/4.3.0'.

Fix Workspaces and gradients lists use full lenght

This separates the aspect ratio from the column count to
allow square sized presets without breaking all other
resources lists.
(cherry picked from commit 17e41a03957f04735488ac711dd100b5ef32ff36)

M  +1    -0    libs/ui/widgets/kis_gradient_chooser.cc
M  +1    -0    libs/ui/widgets/kis_workspace_chooser.cpp
M  +6    -1    libs/widgets/KoTableView.cpp
M  +3    -0    libs/widgets/KoTableView.h

https://invent.kde.org/graphics/krita/commit/216eeaeb6601d41725920b842cfb7b4c092d2928