| Summary: | Krita crashed when undoing | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | crash | CC: | dimula73, gudvinr+kde, nmaghfurusman, tamtamy.tymona |
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | All | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=426424 | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
acc4commissions
2020-06-03 16:45:46 UTC
Since there is a backtrace and two duplicates, let's confirm it. *** Bug 423740 has been marked as a duplicate of this bug. *** *** Bug 424697 has been marked as a duplicate of this bug. *** Note: bug 424697 shows a way to reproduce using a snapshot and assistants. I didn't mark that one as the main bug because this one is the oldest and because I'm not sure if snapshots and assistants are necessary (still, having a way to reproduce is useful). Git commit 945bfad224b0c562dd81b57673fffb8e060855e4 by Dmitry Kazakov. Committed on 11/09/2020 at 20:30. Pushed by dkazakov into branch 'krita/4.3'. Fix a crash when recoverng the assistants via snapshots Resetting the document via snapshots will add the fake decorations layer itself, therefore we shouldn't try to execute syncDecorationsWrapperLayerState() before the actual layers are cloned. Related: bug 424697 M +2 -0 libs/ui/KisDecorationsManager.cpp M +8 -1 libs/ui/KisDocument.cpp M +9 -0 libs/ui/kis_painting_assistants_decoration.cpp M +2 -0 libs/ui/kis_painting_assistants_decoration.h https://invent.kde.org/graphics/krita/commit/945bfad224b0c562dd81b57673fffb8e060855e4 Git commit cd4180b205e0077ec511cc02a73b42cec4ee85f2 by Dmitry Kazakov. Committed on 11/09/2020 at 20:31. Pushed by dkazakov into branch 'master'. Fix a crash when recoverng the assistants via snapshots Resetting the document via snapshots will add the fake decorations layer itself, therefore we shouldn't try to execute syncDecorationsWrapperLayerState() before the actual layers are cloned. Related: bug 424697 M +2 -0 libs/ui/KisDecorationsManager.cpp M +8 -1 libs/ui/KisDocument.cpp M +9 -0 libs/ui/kis_painting_assistants_decoration.cpp M +2 -0 libs/ui/kis_painting_assistants_decoration.h https://invent.kde.org/graphics/krita/commit/cd4180b205e0077ec511cc02a73b42cec4ee85f2 Hi, acc4commissions! Do you remember, did you use any snapshots functionality? The backtrace looks quite like the one in bug 424697, but I don't think that the fix for bug 424697 will actually fix any bugs in undo. Unless you actually used snapshots. Otherwise we'll have to think how to reproduce this bug with undo (theoretically, it is possible and might be related to bug 426424) There was a question asked and unanswered. @acc4 do you remember this crash enough to answer? If not, what should be done about this report? Is the crash log helpful enough? (In reply to Dmitry Kazakov from comment #7) > Hi, acc4commissions! > > Do you remember, did you use any snapshots functionality? > > The backtrace looks quite like the one in bug 424697, but I don't think that > the fix for bug 424697 will actually fix any bugs in undo. Unless you > actually used snapshots. Otherwise we'll have to think how to reproduce this > bug with undo (theoretically, it is possible and might be related to bug > 426424) No I didn't use the snapshot functionality. (In reply to Tymond from comment #8) > There was a question asked and unanswered. @acc4 do you remember this crash > enough to answer? > > If not, what should be done about this report? Is the crash log helpful > enough? It's been a long time and I don't remember the detail. And I don't 'seem' experience this anymore, so I guess it's good for me. At least for now. |